Spec URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec SRPM URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.0.10-1.fc32.src.rpm Description: Rust wrappers for the Notcurses TUI library Fedora Account System Username: nickblack Created with rust2rpm.
Depends on 1907016 and 1907014.
Corrected bug title for correct package name and summary. Also no longer depends on rust-serial_test, it is already packaged.
I've updated the spec to include %license, which was missing in 1907014. I've rebuilt the SRPM against f34, and updated to the current upstream version 2.1.7. https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.0.10-1.fc34.src.rpm
I think you still have copied wrong version :) ~ via 🐍 v3.9.1 ❯ curl https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec -s | grep %license ~ via 🐍 v3.9.1 ❯
augh, i missed the 'fedora-rust' :/ [dank@localhost ~]$ curl https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec | grep -i license % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1972 100 1972 0 0 89636 0 --:--:-- --:--:-- --:--:-- 89636 # Upstream license specification: Apache-2.0 License: ASL 2.0 %license LICENSE-APACHE [dank@localhost ~]$
License is not in the crate: + cp -pr LICENSE-APACHE /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel cp: cannot stat 'LICENSE-APACHE': No such file or directory + : + RPM_EC=0 ++ jobs -p + exit 0 error: File not found: /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel/LICENSE-APACHE RPM build errors: File not found: /builddir/build/BUILDROOT/rust-libnotcurses-sys-2.1.7-1.fc34.x86_64/usr/share/licenses/rust-libnotcurses-sys-devel/LICENSE-APACHE Upstream license file is LICENSE and it is not included in the crate. Ask upstream to do so.
Good catch regarding the `LICENSE`, thanks. I've added it to the crate, and it will be present with the 2.1.8 release. I'm expecting that any day now, so I'll go ahead and push a new spec/SRPM when it drops.
I've: 1) released a new 2.1.8 upstream crate, containing `LICENSE` 2) amended the spec file to point at `LICENSE` rather than `LICENSE-APACHE` 3) updated the spec file for 2.1.8 4) rebuilt the SRPM Spec URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys.spec SRPM URL: https://nick-black.com/tabpower/fedora-rust/rust-libnotcurses-sys-2.1.8-1.fc34.src.rpm The dep is now on libnotcurses 2.1.8, which is slated for rollout to f34. Feel free to PTAL, and thanks for your patience!
- There is a typo here, I assume you meant "Feb" Wed Fed 03 09:37:51 EST 2021 nick black <dankamongmen> - 2.1.8-1 - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved.
Fixed the typo. Thanks so much!
Module requested at https://pagure.io/releng/fedora-scm-requests/issue/32031
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libnotcurses-sys
Package is in repositories (although it is FTB), closing review.