Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other.spec SRPM URL: https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other-5.0.3-1.fc33.src.rpm Description: fcitx-table-other provides some other tables for Fcitx, fork from ibus-table-others, scim-tables. Fedora Account System Username: yanqiyu
as for ownership for %{_datadir}/fcitx5/table, it will be owned by fcitx5-data package then, I will change and update fcitx5 package.
- Remove the multiple trailing spaces - License is GPLv3: License: GPLv3 - Bump to 5.0.3 - Verify the metainfo file at the end of install: BuildRequires: libappstream-glib appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml - Don't include the ChangeLog file as it is empty: fcitx5-table-other.noarch: E: zero-length /usr/share/doc/fcitx5-table-other/ChangeLog - Capitalize the summary: fcitx5-table-other.noarch: W: summary-not-capitalized C other tables for Fcitx5 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 128 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/fcitx5-table-other/review-fcitx5-table- other/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fcitx5-table-other-5.0.2-1.fc35.noarch.rpm fcitx5-table-other-5.0.2-1.fc35.src.rpm fcitx5-table-other.noarch: W: summary-not-capitalized C other tables for Fcitx5 fcitx5-table-other.noarch: W: spelling-error %description -l en_US fcitx -> deficit fcitx5-table-other.noarch: W: spelling-error %description -l en_US ibus -> ibis, bus, i bus fcitx5-table-other.noarch: W: spelling-error %description -l en_US scim -> scum, sci, scrim fcitx5-table-other.noarch: E: zero-length /usr/share/doc/fcitx5-table-other/ChangeLog fcitx5-table-other.src: W: summary-not-capitalized C other tables for Fcitx5 fcitx5-table-other.src: W: spelling-error %description -l en_US fcitx -> deficit fcitx5-table-other.src: W: spelling-error %description -l en_US ibus -> ibis, bus, i bus fcitx5-table-other.src: W: spelling-error %description -l en_US scim -> scum, sci, scrim fcitx5-table-other.src: W: invalid-url Source2: https://pgp.key-server.io/download/0x8E8B898CBF2412F9 HTTP Error 502: Bad Gateway 2 packages and 0 specfiles checked; 1 errors, 9 warnings.
Done. Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other.spec SRPM URL: https://yanqiyu.fedorapeople.org/fcitx5-table-other/fcitx5-table-other-5.0.3-1.fc33.src.rpm Description: fcitx-table-other provides some other tables for Fcitx, fork from ibus-table-others, scim-tables. Fedora Account System Username: yanqiyu
- Summary is still not capitalized: fcitx5-table-other.noarch: W: summary-not-capitalized C other tables for Fcitx5 Summary: Other tables for Fcitx5 Pakage approved, please fix the aforementioned issue before import.
Thank you for the review, Robert-André. I will fix the capitalize. https://pagure.io/releng/fedora-scm-requests/issue/32805
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fcitx5-table-other
Built in rawhide, closing.