Bug 1907566 - Avoid using deprecated kernel command line arguments
Summary: Avoid using deprecated kernel command line arguments
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: general
Version: 28
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Renan Rodrigo Barbosa
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-14 17:56 UTC by Jan Stodola
Modified: 2021-04-16 08:23 UTC (History)
28 users (show)

Fixed In Version:
Clone Of: 1896479
Environment:
Last Closed: 2021-04-09 13:19:03 UTC
Embargoed:


Attachments (Terms of Use)

Description Jan Stodola 2020-12-14 17:56:46 UTC
+++ This bug was initially created as a clone of Bug #1896479 +++

Description of problem:
When installing Fedora-Rawhide (future Fedora 34) in Beaker, the following warnings are printed by the installer:

[    9.574010] dracut-cmdline[299]: Warning: 'ks=<URL>' 
[    9.584962] dracut-cmdline[299]: Warning: ks has been deprecated and will be removed. Please use inst.ks instead. 
[    9.596929] dracut-cmdline[299]: Warning: 'ksdevice=00:00:1A:1B:0B:8C' 
[    9.604937] dracut-cmdline[299]: Warning: ksdevice has been deprecated and will be removed. Please use inst.ks.device instead. 
[    9.637034] dracut-cmdline[299]: Warning: 'ksdevice=<MAC>' is deprecated. Supplied BOOTIF takes precedence. 
...
Boot argument 'leavebootorder' is deprecated and will be removed in the future. Please use 'inst.leavebootorder' instead.
...


* Please, use the proper kernel command line arguments with the "inst" prefix instead of the deprecated arguments.


Version-Release number of selected component (if applicable):
Beaker 27.4

Comment 1 Jan Stodola 2020-12-14 18:36:38 UTC
Git Hub issue: https://github.com/beaker-project/beaker/issues/83

Comment 2 PaulB 2020-12-14 18:55:20 UTC
Beaker-Team,
Looks like this will effect Fedora34+ (and in turn RHEL9) so moving forward we know to use inst.ks.device:
 https://github.com/beaker-project/beaker/issues/83


What is the plan for all the systems currently configured?

Leave all "< [Fedora34 && RHEL9]" system command lines alone and change only "[Fedora34 && RHEL9] =+" ?

Is there some csv magic for this?

Best,
pbunyan

Comment 3 Martin Styk 2020-12-14 19:20:34 UTC
Hi Paul, H5

There is no configuration in this case. Unless someone hardcoded something.
I can replace ks => inst.ks for all new jobs and same applies for ksdevice.

Comment 4 Martin Styk 2020-12-14 19:21:53 UTC
And yes, Fedora34+ & RHEL9+ generated jobs only.

Comment 5 John Villalovos 2020-12-14 19:39:35 UTC
(In reply to PaulB from comment #2)
> Is there some csv magic for this?


As a temporary work-around you can put in the "Kickstart Metadata" the option:  ks_keyword=inst.ks

Comment 6 Jan Stodola 2020-12-14 21:33:01 UTC
(In reply to Martin Styk from comment #3)
> Hi Paul, H5
> 
> There is no configuration in this case. Unless someone hardcoded something.
> I can replace ks => inst.ks for all new jobs and same applies for ksdevice.

and the same for leavebootorder => inst.leavebootorder.

Comment 7 Jan Stodola 2021-02-03 05:33:48 UTC
Hi, what is the status of the bug, please?
The anaconda change [1] is already in review, so there is a high risk that something will break soon...

[1] https://github.com/rhinstaller/anaconda/pull/3136

Comment 8 Jiri Konecny 2021-02-03 08:59:31 UTC
Hello, 

This is an accepted change by Fedora

https://fedoraproject.org/wiki/Changes/Ignore_Anaconda_kernel_boot_parameters_without_inst_prefix

And because of that we have to merge the code before Change Completion Deadline which is Tue 2021-02-09.

Could you please make this a priority to be able to merge this as soon as possible.

Comment 9 PaulB 2021-02-12 19:34:14 UTC
All,
I have opened the following ticket to get the assistance of our admin experts.
We will need their help with changes required for the Beaker systems install options.

RITM0844871: Beaker install options: RHEL9+, Fedora34+, Fedora-Rawhide [inst.ksdevice=<MAC>]
https://redhat.service-now.com/surl.do?n=RITM0844871

Best,
pbunyan

Comment 11 Jiri Konecny 2021-02-16 09:13:52 UTC
(In reply to Martin Styk from comment #3)
> Hi Paul, H5
> 
> There is no configuration in this case. Unless someone hardcoded something.
> I can replace ks => inst.ks for all new jobs and same applies for ksdevice.


Hi Martin, sorry I've missed this comment before.

More precisely, `ks` is now changing to `inst.ks`. However, `ksdevice` does not have any `inst.ksdevice` variant. It's deprecated long time ago so no-one bothered to add `inst.` variant for this. This is rule exception and our current goal is to remove the `ksdevice` Anaconda boot option completely in Fedora soon (F35+).

Comment 12 Anthony Gialluca 2021-02-16 13:32:09 UTC
(In reply to Jiri Konecny from comment #11)
> (In reply to Martin Styk from comment #3)
> > Hi Paul, H5
> > 
> > There is no configuration in this case. Unless someone hardcoded something.
> > I can replace ks => inst.ks for all new jobs and same applies for ksdevice.
> 
> 
> Hi Martin, sorry I've missed this comment before.
> 
> More precisely, `ks` is now changing to `inst.ks`. However, `ksdevice` does
> not have any `inst.ksdevice` variant. It's deprecated long time ago so
> no-one bothered to add `inst.` variant for this. This is rule exception and
> our current goal is to remove the `ksdevice` Anaconda boot option completely
> in Fedora soon (F35+).

Jiri,
Am I to understand that there is no equivalent for 'ks=<MAC ADDR>' going forward ?  There is NO way to specify which network device to install from ?

I ask because there are many beaker systems with different network connections of different types.  Which device is being tested is determined by 'ks=<MAC ADDR>' with in the recopies and provisions. If there is NO replacement I anticipate that we are going to get a lot of push back by Beaker Users.

Comment 13 Anthony Gialluca 2021-02-16 13:44:26 UTC
(In reply to Anthony Gialluca from comment #12)
> (In reply to Jiri Konecny from comment #11)
> > (In reply to Martin Styk from comment #3)
> > > Hi Paul, H5
> > > 
> > > There is no configuration in this case. Unless someone hardcoded something.
> > > I can replace ks => inst.ks for all new jobs and same applies for ksdevice.
> > 
> > 
> > Hi Martin, sorry I've missed this comment before.
> > 
> > More precisely, `ks` is now changing to `inst.ks`. However, `ksdevice` does
> > not have any `inst.ksdevice` variant. It's deprecated long time ago so
> > no-one bothered to add `inst.` variant for this. This is rule exception and
> > our current goal is to remove the `ksdevice` Anaconda boot option completely
> > in Fedora soon (F35+).
> 
> Jiri,
> Am I to understand that there is no equivalent for 'ks=<MAC ADDR>' going
> forward ?  There is NO way to specify which network device to install from ?
> 
> I ask because there are many beaker systems with different network
> connections of different types.  Which device is being tested is determined
> by 'ks=<MAC ADDR>' with in the recopies and provisions. If there is NO
> replacement I anticipate that we are going to get a lot of push back by
> Beaker Users.

For the BUG history, in a separate ticket I have the following bit from Jiri:
If you want to replace functionality of `ksdevice=<MAC>` you should use `bootif=<MAC>` Dracut parameter. When you look on the Anaconda code [0] we are doing the same. We just take `ksdevice` value and put `bootif` there instead.

Comment 14 Jiri Konecny 2021-04-09 11:58:50 UTC
Hi, may I ask what is state of this issue please?

Comment 15 Martin Styk 2021-04-09 12:02:04 UTC
This was incorporated in Beaker 28.2
https://github.com/beaker-project/beaker/releases/tag/beaker-28.2

Released on 16 Feb.

Comment 16 Renan Rodrigo Barbosa 2021-04-09 12:13:42 UTC
Yes, Beaker is not using the deprecated values anymore by default.

However, some systems might have those parameters set by the administrator(s). In this case, the responsibility to update those lies on the system owner.

Comment 17 PaulB 2021-04-09 13:12:15 UTC
All,
Beaker install options corrections were made here:

Beaker install options: RHEL9+, Fedora34+, Fedora-Rawhide [BOOTIF=<M-A-C>]
https://redhat.service-now.com/surl.do?n=RITM0844871

I think  it safe to close this BZ1907566 based on the update completed in RITM0844871.

Best,
pbunyan

Comment 18 Jiri Konecny 2021-04-16 08:23:52 UTC
Thanks a lot for all your work! We will remove the patches from RHEL-9.


Note You need to log in before you can comment on or make changes to this bug.