Bug 1907944 - python-rx fails to build with Python 3.10: TypeError: sleep() got an unexpected keyword argument 'loop'
Summary: python-rx fails to build with Python 3.10: TypeError: sleep() got an unexpect...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-rx
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Carl George 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1969123 (view as bug list)
Depends On:
Blocks: PYTHON3.10 F35FTBFS F35FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2020-12-15 14:59 UTC by Tomáš Hrnčiar
Modified: 2021-06-27 21:01 UTC (History)
5 users (show)

Fixed In Version: python-rx-3.2.0-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-27 21:01:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2020-12-15 14:59:34 UTC
python-rx fails to build with Python 3.10.0a3.

=================================== FAILURES ===================================
______________ TestAsyncIOScheduler.test_asyncio_schedule_action _______________

self = <tests.test_scheduler.test_eventloop.test_asyncioscheduler.TestAsyncIOScheduler testMethod=test_asyncio_schedule_action>

    def test_asyncio_schedule_action(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            scheduler = AsyncIOScheduler(loop)
            ran = False
    
            def action(scheduler, state):
                nonlocal ran
                ran = True
    
            scheduler.schedule(action)
    
            yield from asyncio.sleep(0.1, loop=loop)
            assert ran is True
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:42: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        scheduler = AsyncIOScheduler(loop)
        ran = False
    
        def action(scheduler, state):
            nonlocal ran
            ran = True
    
        scheduler.schedule(action)
    
>       yield from asyncio.sleep(0.1, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:39: TypeError
___________ TestAsyncIOScheduler.test_asyncio_schedule_action_cancel ___________

self = <tests.test_scheduler.test_eventloop.test_asyncioscheduler.TestAsyncIOScheduler testMethod=test_asyncio_schedule_action_cancel>

    def test_asyncio_schedule_action_cancel(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            ran = False
            scheduler = AsyncIOScheduler(loop)
    
            def action(scheduler, state):
                nonlocal ran
                ran = True
    
            d = scheduler.schedule_relative(0.05, action)
            d.dispose()
    
            yield from asyncio.sleep(0.3, loop=loop)
            assert ran is False
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        ran = False
        scheduler = AsyncIOScheduler(loop)
    
        def action(scheduler, state):
            nonlocal ran
            ran = True
    
        d = scheduler.schedule_relative(0.05, action)
        d.dispose()
    
>       yield from asyncio.sleep(0.3, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:81: TypeError
____________ TestAsyncIOScheduler.test_asyncio_schedule_action_due _____________

self = <tests.test_scheduler.test_eventloop.test_asyncioscheduler.TestAsyncIOScheduler testMethod=test_asyncio_schedule_action_due>

    def test_asyncio_schedule_action_due(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            scheduler = AsyncIOScheduler(loop)
            starttime = loop.time()
            endtime = None
    
            def action(scheduler, state):
                nonlocal endtime
                endtime = loop.time()
    
            scheduler.schedule_relative(0.2, action)
    
            yield from asyncio.sleep(0.3, loop=loop)
            assert endtime is not None
            diff = endtime - starttime
            assert diff > 0.18
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:64: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        scheduler = AsyncIOScheduler(loop)
        starttime = loop.time()
        endtime = None
    
        def action(scheduler, state):
            nonlocal endtime
            endtime = loop.time()
    
        scheduler.schedule_relative(0.2, action)
    
>       yield from asyncio.sleep(0.3, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:59: TypeError
____ TestAsyncIOThreadSafeScheduler.test_asyncio_threadsafe_schedule_action ____

self = <tests.test_scheduler.test_eventloop.test_asynciothreadsafescheduler.TestAsyncIOThreadSafeScheduler testMethod=test_asyncio_threadsafe_schedule_action>

    def test_asyncio_threadsafe_schedule_action(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            scheduler = AsyncIOThreadSafeScheduler(loop)
            ran = False
    
            def action(scheduler, state):
                nonlocal ran
                ran = True
    
            def schedule():
                scheduler.schedule(action)
    
            threading.Thread(target=schedule).start()
    
            yield from asyncio.sleep(0.1, loop=loop)
            assert ran is True
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:46: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        scheduler = AsyncIOThreadSafeScheduler(loop)
        ran = False
    
        def action(scheduler, state):
            nonlocal ran
            ran = True
    
        def schedule():
            scheduler.schedule(action)
    
        threading.Thread(target=schedule).start()
    
>       yield from asyncio.sleep(0.1, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:43: TypeError
_ TestAsyncIOThreadSafeScheduler.test_asyncio_threadsafe_schedule_action_cancel _

self = <tests.test_scheduler.test_eventloop.test_asynciothreadsafescheduler.TestAsyncIOThreadSafeScheduler testMethod=test_asyncio_threadsafe_schedule_action_cancel>

    def test_asyncio_threadsafe_schedule_action_cancel(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            ran = False
            scheduler = AsyncIOThreadSafeScheduler(loop)
    
            def action(scheduler, state):
                nonlocal ran
                ran = True
    
            def schedule():
                d = scheduler.schedule_relative(0.05, action)
                d.dispose()
    
            threading.Thread(target=schedule).start()
    
            yield from asyncio.sleep(0.3, loop=loop)
            assert ran is False
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:94: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        ran = False
        scheduler = AsyncIOThreadSafeScheduler(loop)
    
        def action(scheduler, state):
            nonlocal ran
            ran = True
    
        def schedule():
            d = scheduler.schedule_relative(0.05, action)
            d.dispose()
    
        threading.Thread(target=schedule).start()
    
>       yield from asyncio.sleep(0.3, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:91: TypeError
__ TestAsyncIOThreadSafeScheduler.test_asyncio_threadsafe_schedule_action_due __

self = <tests.test_scheduler.test_eventloop.test_asynciothreadsafescheduler.TestAsyncIOThreadSafeScheduler testMethod=test_asyncio_threadsafe_schedule_action_due>

    def test_asyncio_threadsafe_schedule_action_due(self):
        loop = asyncio.get_event_loop()
    
        @asyncio.coroutine
        def go():
            scheduler = AsyncIOThreadSafeScheduler(loop)
            starttime = loop.time()
            endtime = None
    
            def action(scheduler, state):
                nonlocal endtime
                endtime = loop.time()
    
            def schedule():
                scheduler.schedule_relative(0.2, action)
    
            threading.Thread(target=schedule).start()
    
            yield from asyncio.sleep(0.3, loop=loop)
            assert endtime is not None
            diff = endtime - starttime
            assert diff > 0.18
    
>       loop.run_until_complete(go())

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:71: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib64/python3.10/asyncio/base_events.py:641: in run_until_complete
    return future.result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    @asyncio.coroutine
    def go():
        scheduler = AsyncIOThreadSafeScheduler(loop)
        starttime = loop.time()
        endtime = None
    
        def action(scheduler, state):
            nonlocal endtime
            endtime = loop.time()
    
        def schedule():
            scheduler.schedule_relative(0.2, action)
    
        threading.Thread(target=schedule).start()
    
>       yield from asyncio.sleep(0.3, loop=loop)
E       TypeError: sleep() got an unexpected keyword argument 'loop'

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:66: TypeError
=============================== warnings summary ===============================
tests/test_observable/test_fromfuture.py::TestFromFuture::test_future_cancel
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_fromfuture.py:67: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_observable/test_fromfuture.py::TestFromFuture::test_future_dispose
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_fromfuture.py:91: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_observable/test_fromfuture.py::TestFromFuture::test_future_failure
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_fromfuture.py:40: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_observable/test_fromfuture.py::TestFromFuture::test_future_success
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_fromfuture.py:15: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_observable/test_start.py::TestStart::test_start_async
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_start.py:24: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_observable/test_start.py::TestStart::test_start_async_error
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_observable/test_start.py:44: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:29: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action_cancel
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:70: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action_due
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asyncioscheduler.py:48: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:30: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action_cancel
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:77: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action_due
  /builddir/build/BUILD/RxPY-3.1.1/tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py:52: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def go():

-- Docs: https://docs.pytest.org/en/stable/warnings.html
=========================== short test summary info ============================
FAILED tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action
FAILED tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action_cancel
FAILED tests/test_scheduler/test_eventloop/test_asyncioscheduler.py::TestAsyncIOScheduler::test_asyncio_schedule_action_due
FAILED tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action
FAILED tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action_cancel
FAILED tests/test_scheduler/test_eventloop/test_asynciothreadsafescheduler.py::TestAsyncIOThreadSafeScheduler::test_asyncio_threadsafe_schedule_action_due
=========== 6 failed, 1296 passed, 10 skipped, 12 warnings in 12.36s ===========

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01827908-python-rx/

For all our attempts to build python-rx with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-rx/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:34:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Miro Hrončok 2021-06-04 20:13:24 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 3 Miro Hrončok 2021-06-07 22:58:13 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 4 Miro Hrončok 2021-06-08 11:32:37 UTC
*** Bug 1969123 has been marked as a duplicate of this bug. ***

Comment 5 Miro Hrončok 2021-06-15 20:23:48 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 6 Fedora Update System 2021-06-27 20:58:49 UTC
FEDORA-2021-679554941f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-679554941f

Comment 7 Fedora Update System 2021-06-27 21:01:11 UTC
FEDORA-2021-679554941f has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.