Spec URL: https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01832873-megapixels/megapixels-0.13.1-2.fc34.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1832873/ Description: A GTK3 camera application that knows how to deal with the media request api This Camera application is designed specifically for Mobile devices such as PinePhone.
I'll review this. Look for a full review in a bit.
Issues: 1. Why %global debug_package %{nil} ? Don't we want debuginfo? 2. The package seems to include the inih package bundled in. Might see if you can get it to use inih-devel already packaged in Fedora? If not, you may have to Provides: bundled(inih) 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config (either via %dir in files, or changing the globbing) 4. DEBUG util.py:444: warning: bogus date in %changelog: Wed Dec 03 2020 Torrey Sorensen <sorensentor> - 0.12.0-2 The 3rd was a thursday. ;) 5. It doesn't seem to work here on x86_64: Could not read device name from device tree Could not find any config file Is it arm specific? If so, perhaps a ExclusiveArch ? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 47 files have unknown license. Detailed output of licensecheck in /home/kevin/megapixels/review- megapixels/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/megapixels, /usr/share/megapixels/config [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/megapixels/config, /usr/share/megapixels [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: megapixels-0.13.1-2.fc34.x86_64.rpm megapixels-0.13.1-2.fc34.src.rpm megapixels.x86_64: W: spelling-error Summary(en_US) api -> API, pi, ape megapixels.x86_64: W: spelling-error %description -l en_US api -> API, pi, ape megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels-camera-test megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels-list-devices megapixels.x86_64: W: no-manual-page-for-binary megapixels megapixels.x86_64: W: no-manual-page-for-binary megapixels-camera-test megapixels.x86_64: W: no-manual-page-for-binary megapixels-list-devices megapixels.src: W: spelling-error Summary(en_US) api -> API, pi, ape megapixels.src: W: spelling-error %description -l en_US api -> API, pi, ape megapixels.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 17) megapixels.src: E: specfile-error warning: bogus date in %changelog: Wed Dec 03 2020 Torrey Sorensen <sorensentor> - 0.12.0-2 2 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- megapixels.x86_64: W: spelling-error Summary(en_US) api -> API, pi, ape megapixels.x86_64: W: spelling-error %description -l en_US api -> API, pi, ape megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels-camera-test megapixels.x86_64: W: unstripped-binary-or-object /usr/bin/megapixels-list-devices megapixels.x86_64: W: no-manual-page-for-binary megapixels megapixels.x86_64: W: no-manual-page-for-binary megapixels-camera-test megapixels.x86_64: W: no-manual-page-for-binary megapixels-list-devices 1 packages and 0 specfiles checked; 0 errors, 8 warnings. Source checksums ---------------- https://git.sr.ht/~martijnbraam/megapixels/archive/0.13.1.tar.gz : CHECKSUM(SHA256) this package : 2968ede5734b6356f48007ce77708ef7437294a964ec789977fe58226e2a53fd CHECKSUM(SHA256) upstream package : 2968ede5734b6356f48007ce77708ef7437294a964ec789977fe58226e2a53fd Requires -------- megapixels (rpmlib, GLIBC filtered): /usr/bin/sh dcraw hicolor-icon-theme libc.so.6()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libpthread.so.0()(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) rtld(GNU_HASH) Provides -------- megapixels: application() application(org.postmarketos.Megapixels.desktop) megapixels megapixels(x86-64) metainfo() metainfo(org.postmarketos.Megapixels.metainfo.xml) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -n megapixels Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Haskell, Ocaml, SugarActivity, PHP, Python, Java, fonts, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> 1. Why %global debug_package %{nil} ? Don't we want debuginfo? We do :) > 2. The package seems to include the inih package bundled in. > Might see if you can get it to use inih-devel already packaged in Fedora? > If not, you may have to Provides: bundled(inih) It might be a fork due to something not upstream, or requiring a non stable/LTS release, if that's the case it should be documented why with comments and if the former to a ticket for resolution. > 5. It doesn't seem to work here on x86_64: > > Could not read device name from device tree > Could not find any config file > > Is it arm specific? If so, perhaps a ExclusiveArch ? Looking at the upstream it states "As first step it will get the first compatible name in the device tree" and reading further on it's VERY dependent on specific sensors and SoCs so yes, it should be ExclusiveArch to the two arm arches, it would work with some ARMv7 devices too but I doubt it would work with the Raspberry Pi. Ultimately in the short term I think this is fine, in the medium term an app based on libcamera is what we'll actually need TBH.
Spec URL: https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-aarch64/01841904-megapixels/megapixels-0.13.1-2.fc34.src.rpm Copr Build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1841904/ > 1. Why %global debug_package %{nil} ? Don't we want debuginfo? Yes, we want debuginfo. Removed that line. > 2. The package seems to include the inih package bundled in. > Might see if you can get it to use inih-devel already packaged in Fedora? > If not, you may have to Provides: bundled(inih) I added inih-devel to BuildRequires. > 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config > (either via %dir in files, or changing the globbing) Fixed :) > 4. DEBUG util.py:444: warning: bogus date in %changelog: > Wed Dec 03 2020 Torrey Sorensen <sorensentor> - 0.12.0-2 > The 3rd was a thursday. ;) oof, that was dumb of me. > 5. It doesn't seem to work here on x86_64: As mentioned I added ExclusiveArch for the two arm arches. Tested and still works "as expected" on the PinePhone. Thank you for the review.
(In reply to Torrey Sorensen from comment #4) > Spec URL: > https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora- > rawhide-aarch64/01841904-megapixels/megapixels-0.13.1-2.fc34.src.rpm > Copr Build: > https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1841904/ > > > 1. Why %global debug_package %{nil} ? Don't we want debuginfo? > > Yes, we want debuginfo. Removed that line. Thanks. > > 2. The package seems to include the inih package bundled in. > > Might see if you can get it to use inih-devel already packaged in Fedora? > > If not, you may have to Provides: bundled(inih) > > I added inih-devel to BuildRequires. It doesn't seem to be using it? Not a blocker, but perhaps ask upstream to detect and use a system version if available? > > 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config > > (either via %dir in files, or changing the globbing) > > Fixed :) Thanks. > > 4. DEBUG util.py:444: warning: bogus date in %changelog: > > Wed Dec 03 2020 Torrey Sorensen <sorensentor> - 0.12.0-2 > > The 3rd was a thursday. ;) > > oof, that was dumb of me. Naw, happens to everyone. ;) > > 5. It doesn't seem to work here on x86_64: > > As mentioned I added ExclusiveArch for the two arm arches. > > Tested and still works "as expected" on the PinePhone. > > > Thank you for the review. Cool. All blockers I see are fixed. Please check into the inih thing with upstream when you get a chance... This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/megapixels