Description of problem:
When using discovery rules, discovered hosts may be assigned a random taxonomy by Satellite. Satellite may say it assigned a different taxonomy right next (one that makes sense given e.g. the discovered host's subnet) but the newly assigned taxonomy will be disregarded when loading discovery rules.

As a result, discovery rules are loaded and matched as if the host still belonged to the randomly assigned taxonomy, not the actual taxonomy.

This can be worked around by setting the discovery_location and discovery_organization settings on Satellite to the correct ones the discovered host belongs to. However, if one wants to discover hosts in two or more different taxonomies and wants discovery rules to correctly load and match, this workaround does not fix the issue.


This has been resolved at least in part upstream: https://projects.theforeman.org/issues/30948


Version-Release number of selected component (if applicable):
foreman-2.1.2.21-1.el7sat.noarch
tfm-rubygem-foreman_discovery-16.1.2-1.el7sat.noarch
tfm-rubygem-smart_proxy_discovery-1.0.5-5.el7sat.noarch

How reproducible:
Every single time if a host's actual taxonomy does not match Satellite's default discovery taxonomy.

Steps to Reproduce:
1. Set Satellite's default discovery location to L2 or leave it undefined.
2. Have discovery rules in place for L1 that differ from the ones in L2.
3. Have a subnet S1 belonging to location L1 only.
4. Discover a host in S1 and L1.

Actual results:
Satellite loads discovery rules for L2 and none of them match; discovery rules do not work. But Satellite correctly re-assigns the host's location to L1. If one re-sends the discovery facts from the host, Satellite then loads discovery rules for L1 location and one of them finally matches the host, so the host reboots automatically to a functioning provisioning workflow.

Expected results:
Satellite figures out the host's taxonomy based on at least its subnet and correctly loads discovery rules accordingly, so one of those rules matches and automated discovery ensues.


Additional info:
Per lzap, this patch may need to be backported: https://github.com/theforeman/foreman_discovery/pull/509/files