Bug 1908020
| Summary: | "Providers" link in the "Host details" page should point to the correct "Provider" tab | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Migration Toolkit for Virtualization | Reporter: | Md Nadeem <mnadeem> | ||||||
| Component: | General | Assignee: | Mike Turley <mturley> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Ilanit Stein <istein> | ||||||
| Severity: | low | Docs Contact: | Avital Pinnick <apinnick> | ||||||
| Priority: | low | ||||||||
| Version: | 2.0.0 | CC: | fdupont, gdubreui, istein, mturley, vconzola | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | 2.0.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-06-10 17:11:27 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Md Nadeem
2020-12-15 17:23:33 UTC
Interesting, on my end it always takes me to the VMware tab first. I need to revisit that logic. We can probably persist this tab selection as part of the URL route. This has been addressed upstream on master branch and backported to release-v2.0.0-beta-2.0 with https://github.com/konveyor/forklift-ui/pull/344 @Mike, Checked on OCP-4.7/CNV-2.6 with downstream MTV installed. I attached the page of VMware provider hosts. I see that there is a 'VMware' link that allows to go back to VMware providers page, Also when clicking the 'Providers' link it opens the 'Openshift-virtualization' page. Does this reflect what was implemented for this RFE, or maybe a newer version is required to verify it? Created attachment 1746611 [details]
VMware hosts page
Ilanit, Yes, this is the behavior implemented for this RFE (the VMware link going to the VMware page). I realize now that it may be confusing for the Providers link to also still exist, which takes you to the Providers page with no provider type specified (just as if you clicked Providers in the navigation menu). This just brings you to the first available provider type as returned by the inventory API. Perhaps we should remove the Providers link from the breadcrumb bar and leave only the VMware link there. Or do you think it's okay as it is? - Mike @Mike, Thanks for explaining. The purpose of the bug as I understand is to ease the user that is in a specific provider Hosts page, in going back to this specific provider page. This can be done for example, by adding a link to the 'Specific VMware provider name', Like this: 'Providers' link->'VMware' link->'Specific VMware provider name' link-->Hosts Another option can be: Cancel the Providers link: 'Providers'->'VMware' link->'Specific VMware provider name' link-->Hosts and from the 'VMware' page have the 'Providers' link. @Ilanit, the reason we don't link directly to a specific provider is because there is no dedicated page for a specific provider (aside from the host page itself). The user navigates from a list of providers of a given type to the hosts for that provider, so the breadcrumb bar reflects that organization. If we added a link to a specific provider it would have to do something like go to the provider list and scroll down to that provider, which is awkward and will not have any effect if there are not a lot of providers. I'm curious about @Vince's opinion on this. I think what I'd like to do is remove the link from the text Providers and only have the VMware link. There is really only one place to navigate back to anyway, and it is the list of VMware providers. Providers -> [VMware] (link) -> Provider name -> Hosts Mike, considering the limitations, what you offered seems OK to me. Sounds good. Fixed and backported in https://github.com/konveyor/forklift-ui/pull/379. Should be all set now The d/s image is build. Deleting the forklift-ui pod will pull it. Verified on OCP-4.7/CNV-2.6.0 by Deleting the forklift-ui pod. Attached the nee appearance screenshot. Created attachment 1748284 [details]
new_appearance
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (MTV 2.0.0 images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:2381 |