Bug 1908020 - "Providers" link in the "Host details" page should point to the correct "Provider" tab
Summary: "Providers" link in the "Host details" page should point to the correct "Prov...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: General
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 2.0.0
Assignee: Mike Turley
QA Contact: Ilanit Stein
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-15 17:23 UTC by Md Nadeem
Modified: 2021-06-10 17:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-10 17:11:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
VMware hosts page (45.68 KB, image/png)
2021-01-12 11:48 UTC, Ilanit Stein
no flags Details
new_appearance (36.72 KB, image/png)
2021-01-17 16:44 UTC, Ilanit Stein
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2021:2381 0 None None None 2021-06-10 17:11:37 UTC

Description Md Nadeem 2020-12-15 17:23:33 UTC
Description of problem:

When a user click host number of a provider, it navigate to host detail page, however getting back to the same provider is not a single click task.

For Example, if the user on the host page of a vmware provider name vsphere65, you will see a navigation option on top of page as "Providers<hyperlink>-->vsphere65--->Hosts"

1. Click on hyperlink "providers" 
2. It will by default navigate you to "openshift virtualization" page
3. Switch tab to your provider, in my case it is "vmware"
4. Find the target provider row

For a better user experience, It should be a single click task, at least clicking on "providers" hyperlink should navigate you to the respective provider page 
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Mike Turley 2020-12-15 21:41:15 UTC
Interesting, on my end it always takes me to the VMware tab first. I need to revisit that logic. We can probably persist this tab selection as part of the URL route.

Comment 2 Gilles Dubreuil 2020-12-17 22:07:25 UTC
This has been addressed upstream on master branch and backported to release-v2.0.0-beta-2.0 with https://github.com/konveyor/forklift-ui/pull/344

Comment 3 Ilanit Stein 2021-01-12 11:46:37 UTC
@Mike,
Checked on OCP-4.7/CNV-2.6 with downstream MTV installed.

I attached the page of VMware provider hosts.
I see that there is a 'VMware' link that allows to go back to VMware providers page,
Also when clicking the 'Providers' link it opens the 'Openshift-virtualization' page.

Does this reflect what was implemented for this RFE, or maybe a newer version is required to verify it?

Comment 4 Ilanit Stein 2021-01-12 11:48:28 UTC
Created attachment 1746611 [details]
VMware hosts page

Comment 5 Mike Turley 2021-01-12 17:23:20 UTC
Ilanit,

Yes, this is the behavior implemented for this RFE (the VMware link going to the VMware page). I realize now that it may be confusing for the Providers link to also still exist, which takes you to the Providers page with no provider type specified (just as if you clicked Providers in the navigation menu). This just brings you to the first available provider type as returned by the inventory API.

Perhaps we should remove the Providers link from the breadcrumb bar and leave only the VMware link there. Or do you think it's okay as it is?

- Mike

Comment 6 Ilanit Stein 2021-01-13 07:56:14 UTC
@Mike,

Thanks for explaining.

The purpose of the bug as I understand is to ease the user that is in a specific provider Hosts page,
in going back to this specific provider page.

This can be done for example, by adding a link to the 'Specific VMware provider name',
Like this:
'Providers' link->'VMware' link->'Specific VMware provider name' link-->Hosts
 
Another option can be: Cancel the Providers link:
'Providers'->'VMware' link->'Specific VMware provider name' link-->Hosts  
and from the 'VMware' page have the 'Providers' link.

Comment 7 Mike Turley 2021-01-13 17:15:10 UTC
@Ilanit, the reason we don't link directly to a specific provider is because there is no dedicated page for a specific provider (aside from the host page itself). The user navigates from a list of providers of a given type to the hosts for that provider, so the breadcrumb bar reflects that organization. If we added a link to a specific provider it would have to do something like go to the provider list and scroll down to that provider, which is awkward and will not have any effect if there are not a lot of providers.

I'm curious about @Vince's opinion on this. I think what I'd like to do is remove the link from the text Providers and only have the VMware link. There is really only one place to navigate back to anyway, and it is the list of VMware providers.

Providers -> [VMware] (link) -> Provider name -> Hosts

Comment 8 Ilanit Stein 2021-01-13 18:53:28 UTC
Mike,
considering the limitations, what you offered seems OK to me.

Comment 9 Mike Turley 2021-01-13 20:13:22 UTC
Sounds good. Fixed and backported in https://github.com/konveyor/forklift-ui/pull/379. Should be all set now

Comment 10 Fabien Dupont 2021-01-13 20:33:49 UTC
The d/s image is build. Deleting the forklift-ui pod will pull it.

Comment 11 Ilanit Stein 2021-01-17 16:44:05 UTC
Verified on OCP-4.7/CNV-2.6.0 by Deleting the forklift-ui pod.
Attached the nee appearance screenshot.

Comment 12 Ilanit Stein 2021-01-17 16:44:36 UTC
Created attachment 1748284 [details]
new_appearance

Comment 17 errata-xmlrpc 2021-06-10 17:11:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381


Note You need to log in before you can comment on or make changes to this bug.