Description of problem: When navigating to the VMware provider host page, There is a blank value for a column like Network name, Bandwidth, MTU, Status. The might get fixed after the below upstream issues addressed. - https://github.com/konveyor/forklift-controller/issues/120 - https://github.com/konveyor/forklift-ui/issues/292 Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
I believe this will be resolved by https://github.com/konveyor/forklift-ui/pull/427. @Fabien, that PR assumes the network named "Management Network" will always be the default. Is that a safe assumption?
This was fixed as part of https://github.com/konveyor/forklift-ui/pull/427
This fix should be part of build v2.0.0-14, iib:64369.
Created attachment 1773623 [details] MTV_VMware_hosts Columns are still empty (please see attached) Is it expected? According to this PR: https://github.com/konveyor/forklift-ui/pull/427 - a host without a CR will now display "Management Network" with its correct bandwidth and MTU in the table instead of just "(default)"
I think I know what the problem is. The "managementServerIp" attribute is not the address of the host on the management network, but the address of the vCenter that manages the host. Mike, to identify the management network, we need to identify the item in networkAdapters whose "ipAddress" + "subnetMask" matches the "managementServerIp". From a function point of view, you need to compute the network range based on the "ipAddress" and "subnetMask" for each network adapter, then pick the one that contains "managementServerIp". PR: https://github.com/konveyor/forklift-ui/pull/546
That makes sense Fabien. Thanks for investigating and fixing it. I'm glad the netmask library I was already using there was able to solve it conveniently.
This fix should be part of build v2.0.0-19, iib:68535.
2.0.0-20 (iib:69034) Status is still missing
@amastbau that is expected, although maybe it indicates a confusing UI detail. That status column shows conditions on the Host CRs, which only exist for hosts that have a non-default network configured (it's showing whether setting that network was successful). When the management network is selected, there is no Host CR, it lets the controller handle network selection and just shows the known details of the default network. So there is no status to show in that case. If you select a non-default network for that host, a status should appear. @vconzola maybe we should add something to fill that empty status space? I'm not sure if a green check with "Ready" or "Ok" is appropriate since we have no idea if that host/network are okay, we just know they are untouched / not configured for anything but the default. Maybe N/A or something? At any rate I think the bug is fixed, it's working as intended. If we want something better in that column for default networks I think that is a separate RFE.
I agree @vconzola if you believe the second RFE make since, we will open this other BZ (i think it does).
@mturley Does, or can, the user do anything with the host status information? It sounds like its only reason for being to let the user know that they successfully changed the migration network selection. Is that right? If so, why don't we just ditch the Status column and show success/failure in a toast notification. If it succeeds, then show the new network name in the Network column. If it fails, continue to show "management network". @amastbau Please open an RFE BZ for us to address this in a future release.
@vconzola technically that status info is anything that will ever show on the Host CR, any issues related to any kind of configuration of a host. Right now we're just using it for the network selection though, so yes. The problem with a toast notification here is that a failure is not a no-op, it puts the host into a broken state where it may be configured with a network that can't be used or something. A toast could notify them but then once it's dismissed or the user leaves and comes back, there's no indication that anything is wrong. What I could maybe do is get rid of the status column, perhaps add a toast notification, and if there are any errors with the Host CR I could display a status icon next to the migration network name, with a popover? Let's transfer this discussion to the RFE BZ.
@amastbau, once you have opened the RFE BZ, could this one be marked VERIFIED?
Followup RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1953989 +Verified The Status reflects the host CR status (fail+ready)
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (MTV 2.0.0 images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:2381