Bug 1908265 - Custom /usr/lib/ocf/resource.d/linbit/drbd is broken, upstream variant works
Summary: Custom /usr/lib/ocf/resource.d/linbit/drbd is broken, upstream variant works
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: drbd
Version: epel8
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Peter Hanecak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-16 09:24 UTC by Robert Scheck
Modified: 2021-01-25 01:35 UTC (History)
4 users (show)

Fixed In Version: drbd-9.15.1-2.fc33 drbd-9.15.1-2.fc32 drbd-9.15.1-2.el8 drbd-9.15.1-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-18 01:33:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Robert Scheck 2020-12-16 09:24:28 UTC
Description of problem:
As of writing, the custom /usr/lib/ocf/resource.d/linbit/drbd as shipped by drbd-pacemaker-9.13.1-1.el8.x86_64 is broken.

Version-Release number of selected component (if applicable):
drbd-pacemaker-9.13.1-1.el8.x86_64

How reproducible:
Always, see above and below.

Actual results:
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 318: USAGE:: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 320: Commands:: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 321: primary: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 322: secondary: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 323: attach: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 324: disk-options: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 325: detach: command not found ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: eval: line 326: syntax error near unexpected token `(' ]
Dec 16 05:51:36 drbd1 pacemaker-execd[12629]: notice: data_drbd_monitor_0[15632] error output [ /usr/lib/ocf/resource.d/linbit/drbd: eval: line 326: ` connect - Attempt to (re)establish a replication link to a peer host.' ] 

Expected results:
Working OCF resource.

Additional info:
Replacing /usr/lib/ocf/resource.d/linbit/drbd with drbd-utils-9.13.1/scripts/drbd.ocf starts to make things working. Why is a custom variant ("fork") rather pristine upstream used?

Comment 1 Robert Scheck 2020-12-16 09:58:01 UTC
https://src.fedoraproject.org/rpms/drbd/pull-request/1 is my suggestion, while afterwards a merge from master to epel7/epel8 branch should happen.

Comment 2 John 2020-12-31 03:39:31 UTC
Yep.

Utterly broken.

Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 318: USAGE:: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 320: Commands:: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 321: primary: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 322: secondary: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 323: attach: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 324: disk-options: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: line 325: detach: command not found ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: eval: line 326: syntax error near unexpected token `(' ]
Dec 31 14:27:23 audctstmr001.au.harveynorman.com pacemaker-execd     [12520] (log_op_output)    notice: drbd0_monitor_0[20347] error output [ /usr/lib/ocf/resource.d/linbit/drbd: eval: line 326: `    connect - Attempt to (re)establish a replication link to a peer host.' ]


[root@audctstmr001 12-31 14:37:38 ~]# rpm -q drbd-pacemaker
drbd-pacemaker-9.13.1-1.el8.x86_64

Comment 3 John 2020-12-31 03:51:32 UTC
I grabbed the upstream one for version 9.13.1, it is 20 KB bigger than the one in drbd-pacemaker-9.13.1-1.el8.x86_64

[root@audctstmr001 12-31 14:46:17 ~]# ll /usr/lib/ocf/resource.d/linbit/drbd ~/drbd.ocf
-rw-r--r-- 1 root root 56306 Dec 31 14:43 /root/drbd.ocf
-rwxr-xr-x 1 root root 35410 Jun 13  2020 /usr/lib/ocf/resource.d/linbit/drbd

Just... incredible.

Comment 4 John 2020-12-31 04:03:46 UTC
Yep, as Robert says, it works, if you replace the garbage file at: 
   /usr/lib/ocf/resource.d/linbit/drbd
with the upstream version i grabbed from here:
   https://fossies.org/linux/misc/drbd-utils-9.13.1.tar.gz/drbd-utils-9.13.1/scripts/drbd.ocf?m=b


Now drbd resource has promoted to master and looks good:
Dec 31 14:55:45 audctstmr001.au.harveynorman.com pacemaker-schedulerd[12522] (pcmk__set_instance_roles)         info: drbd0-clone: Promoted 1 instances of a possible 1 to master

Many thanks Robert.

Comment 5 Peter Hanecak 2021-01-09 16:39:28 UTC
Thanks for report and pull-request. Working through it now. New builds will be done shortly.

Comment 6 Fedora Update System 2021-01-09 17:05:42 UTC
FEDORA-EPEL-2021-8ae9a2be63 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8ae9a2be63

Comment 7 Fedora Update System 2021-01-09 17:06:36 UTC
FEDORA-EPEL-2021-76e4815d51 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-76e4815d51

Comment 8 Fedora Update System 2021-01-09 17:07:09 UTC
FEDORA-2021-33feed9879 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-33feed9879

Comment 9 Fedora Update System 2021-01-09 17:07:27 UTC
FEDORA-2021-7f35438f58 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7f35438f58

Comment 10 Fedora Update System 2021-01-10 01:35:12 UTC
FEDORA-2021-7f35438f58 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7f35438f58`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7f35438f58

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-01-10 01:39:25 UTC
FEDORA-EPEL-2021-76e4815d51 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-76e4815d51

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-01-10 01:46:01 UTC
FEDORA-EPEL-2021-8ae9a2be63 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8ae9a2be63

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-01-10 02:17:45 UTC
FEDORA-2021-33feed9879 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-33feed9879`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-33feed9879

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-01-18 01:33:50 UTC
FEDORA-2021-7f35438f58 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-01-18 02:20:21 UTC
FEDORA-2021-33feed9879 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2021-01-25 01:23:56 UTC
FEDORA-EPEL-2021-76e4815d51 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2021-01-25 01:35:45 UTC
FEDORA-EPEL-2021-8ae9a2be63 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.