Bug 1908631 - [RFE]Doc: add leases related info in formatnetwork.html
Summary: [RFE]Doc: add leases related info in formatnetwork.html
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.3
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: 8.4
Assignee: Michal Privoznik
QA Contact: yalzhang@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-17 08:21 UTC by yalzhang@redhat.com
Modified: 2021-05-25 06:47 UTC (History)
5 users (show)

Fixed In Version: libvirt-7.0.0-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-25 06:46:30 UTC
Type: Feature Request
Target Upstream Version: 7.0.0
Embargoed:


Attachments (Terms of Use)

Description yalzhang@redhat.com 2020-12-17 08:21:01 UTC
Description of problem:
Commit 97a0aa24 add the support to configure dhcp lease time in network definition, but there is no description about it in /usr/share/doc/libvirt-docs/html/formatnetwork.html

Version-Release number of selected component (if applicable):
libvirt-6.3.0 and above

How reproducible:
100%

Steps to Reproduce:
1. The patch to introduce the feature, refer to https://www.redhat.com/archives/libvir-list/2020-April/msg00746.html


Actual results:

Expected results:

Additional info:

Comment 1 Michal Privoznik 2020-12-18 15:10:05 UTC
Patch posted upstream (as a part of a bigger series):

https://www.redhat.com/archives/libvir-list/2020-December/msg00812.html

Comment 2 Michal Privoznik 2021-01-04 14:36:36 UTC
Merged upstream as:

7f93905e45 nss: handle leases with infinite expiry time
5dd53684e1 networkGetDHCPLeases: Handle leases with infinite expiry time
5fb6d98c88 network: Rework networkGetDHCPLeases()
ee93656c40 networkGetDHCPLeases: Use VIR_APPEND_ELEMENT() instead of VIR_INSERT_ELEMENT()
9c65363a40 network: Drop @custom_lease_file_len variable from networkGetDHCPLeases()
6f1ae57129 virlease: Allow infinite lease expiry time
003fff38e7 virlease: Use virTrimSpaces() instead of open coded alternative
8e5659ed12 virlease: Rework virLeaseReadCustomLeaseFile()
c14bd64f3e leaseshelper: Report errors on failure
49869e8d57 docs: Document ability to configure lease time

v6.10.0-281-g7f93905e45

Comment 3 Michal Privoznik 2021-01-04 14:41:52 UTC
Moving to POST per comment 2.

Comment 7 yalzhang@redhat.com 2021-01-22 03:18:47 UTC
Checked on https://libvirt.org/formatnetwork.html#elementsAddress and /usr/share/doc/libvirt-docs/html/formatnetwork.html, it is expected.

Comment 9 errata-xmlrpc 2021-05-25 06:46:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:av bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2098


Note You need to log in before you can comment on or make changes to this bug.