Bug 1908650 - The title of customize wizard is inconsistent
Summary: The title of customize wizard is inconsistent
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.7
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.7.0
Assignee: Gilad Lekner
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-17 09:22 UTC by Guohua Ouyang
Modified: 2021-02-24 15:46 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:46:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
new wizard create from common template (119.87 KB, image/png)
2021-01-05 06:55 UTC, Yaacov Zamir
no flags Details
old wizard create from common-template (120.55 KB, image/png)
2021-01-05 06:55 UTC, Yaacov Zamir
no flags Details
new wizard create from user template (121.65 KB, image/png)
2021-01-05 06:56 UTC, Yaacov Zamir
no flags Details
old wizard create from user template (123.79 KB, image/png)
2021-01-05 06:56 UTC, Yaacov Zamir
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 7728 0 None closed Bug 1908650: The title of customize wizard is inconsistent 2021-01-11 06:59:37 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:46:37 UTC

Description Guohua Ouyang 2020-12-17 09:22:58 UTC
Description of problem:
When click customize button: 
- If the template has boot source, title is 'Create Virtual Machine from ......'
- If the template has no boot source, title is 'Create Virtual Machine'

There is inconsistence when the template with boot source or without boot source.

Version-Release number of selected component (if applicable):
OCP 4.7

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Gilad Lekner 2020-12-27 13:23:49 UTC
I'm seeing "Create Virtual Machine" Alone in both cases.
can you make sure the reproducing steps work?

Thanks

Comment 2 Guohua Ouyang 2020-12-28 00:54:53 UTC
Ah, it seems only happen when the template is created by user, such as create a template from yaml and use it to create the VM, then the title is "Create Virtual Machine from vm-template-example".

Comment 3 Yaacov Zamir 2020-12-28 06:34:38 UTC
Gilad, Guohua hi, IMHO in the new flow where common-templates are used the same way as user-templates, we should show the "from template ..." in both cases, WDYT ?

Comment 4 Guohua Ouyang 2020-12-28 09:47:27 UTC
(In reply to Yaacov Zamir from comment #3)
> Gilad, Guohua hi, IMHO in the new flow where common-templates are used the
> same way as user-templates, we should show the "from template ..." in both
> cases, WDYT ?

I have no problem with this. 

What about when the template has no source available, it's "Create Virtual Machine", looks like we don't consider it's creating from a template through we select a template at the first step.

Comment 5 Gilad Lekner 2020-12-29 08:36:13 UTC
Hey @mcarleto
can you please give your input here

Comment 6 Matt 2021-01-04 20:16:51 UTC
In this scenario, they are creating a VM from a template with a custom boot source right?
If that's true we should still say Which template they are creating from but clarify they are adding a custom boot source.

Create virtual machine from template-x with custom boot source"
WDYT?

Comment 7 Yaacov Zamir 2021-01-05 06:50:01 UTC
Matt Gilad hi,

currently after a user selects a template, and choose "customize this VM", in the old wizard (the complicated one with 6 tabs) we show the title:

for templates provided by community / user : we show "create VM from template <user template name>"
for templates provided by redhat           : we show "create VM"

[ this bug doesn't exist in the new wizard where we have help text that expose the template name the same way for community and redhat provided templates ]

the bug is why the old wizard hide the template name in the case of redhat provided common-templates ?

@Matt, the question is:
Do we hide the template name in the old wizard by design, or is it a bug and we should show the template name in a simmilar way to the way we do in the new wizard ?

Comment 8 Yaacov Zamir 2021-01-05 06:55:04 UTC
Created attachment 1744492 [details]
new wizard create from common template

Comment 9 Yaacov Zamir 2021-01-05 06:55:41 UTC
Created attachment 1744493 [details]
old wizard create from common-template

Comment 10 Yaacov Zamir 2021-01-05 06:56:13 UTC
Created attachment 1744494 [details]
new wizard create from user template

Comment 11 Yaacov Zamir 2021-01-05 06:56:49 UTC
Created attachment 1744495 [details]
old wizard create from user template

Comment 12 Matt 2021-01-05 15:47:00 UTC
we should always show the name of the template they are creating from, yes.

Comment 16 errata-xmlrpc 2021-02-24 15:46:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.