RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1908724 - [SR-IOV] [i40e] After setting SR-IOV number of VFs, nmstate reports success before VFs links are created in kernel
Summary: [SR-IOV] [i40e] After setting SR-IOV number of VFs, nmstate reports success b...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: nmstate
Version: 8.4
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: rc
: 8.0
Assignee: Gris Ge
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks: 1911642
TreeView+ depends on / blocked
 
Reported: 2020-12-17 12:40 UTC by Michael Burman
Modified: 2021-05-18 15:18 UTC (History)
9 users (show)

Fixed In Version: nmstate-1.0.1-0.1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1911642 (view as bug list)
Environment:
Last Closed: 2021-05-18 15:18:22 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
verified.log (8.49 KB, text/plain)
2021-01-06 08:31 UTC, Mingyu Shi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github nmstate nmstate pull 1453 0 None closed sriov: Use verification retry to wait VF been created 2021-01-18 11:09:35 UTC

Description Michael Burman 2020-12-17 12:40:08 UTC
Description of problem:
[SR-IOV] [i40e] After setting sriov number of vfs, nmstate reports success before vfs links are created in kernel

Version-Release number of selected component (if applicable):
nmstate-0.3.4-14.el8_3.noarch

How reproducible:
100% on 'i40e' driver hosts

Steps to Reproduce:
1. Enable VFs on a i40e driver server

Actual results:
nmstate report success too early, much early before it is visible on the kernel. 
This way RHV missing the refresh caps event and the correct number of VFS is not visible in the RHV admin. This will lead to bad leftovers on RHV side and this is currently totally blocking the entire SR-IOV testing on a 'i40e' driver hosts.
Looks like i40e cards response a bit slower than a 'igb' or igbx driver.

Expected results:
nmstate should report success only after all the VFs are created and visible on the kernel

Additional info:
1. Reproduced 100% on a i40e driver hosts, seems they a bit slower than igb drivers.
2. This is totally blocking the entire SR-IOV testing on our i40e driver environments. Pls try to resolve ASAP. 
3. If you will need a i40e driver host, feel free to contact me.

Comment 4 Michael Burman 2020-12-17 12:41:46 UTC
This is the nmstate reproducer(without RHV):

    #!/bin/bash -xe
     
    # This must be i40e driver!
    SRIOV=eth0
     
     
    cat << EOF > sriov.yaml
    ---
    interfaces:
    - name: $SRIOV
      state: up
      ethernet:
        sr-iov:
          total-vfs: 2
          vfs:
          - id: 0
          - id: 1
    EOF
     
    nmstatectl set sriov.yaml && nmstatectl show | grep "$SRIOV"
    nmstatectl set sriov.yaml  && sleep 2 && nmstatectl show | grep "$SRIOV"

Comment 6 Gris Ge 2020-12-18 01:57:39 UTC
Thanks for the logs. I will take a look.

Comment 9 Gris Ge 2020-12-30 08:04:19 UTC
Patch posted to https://github.com/nmstate/nmstate/pull/1453

Once copr repo created there. Please test it.

Comment 12 Michael Burman 2020-12-30 09:08:00 UTC
(In reply to Gris Ge from comment #9)
> Patch posted to https://github.com/nmstate/nmstate/pull/1453
> 
> Once copr repo created there. Please test it.

Hi Gris, the fix looks good!
Tested nmstate-1.0.1-0.20201230080835942541.pr1453.11.g626b426.el8.noarch 
It fixes the issue on 'i40e' driver hosts and everything works as expected with this patch.

Comment 17 Mingyu Shi 2021-01-06 08:29:13 UTC
Verified with versions:
nmstate-1.0.1-0.1.el8.noarch
nispor-1.0.1-2.el8.x86_64
NetworkManager-1.30.0-0.5.el8.x86_64

Comment 18 Mingyu Shi 2021-01-06 08:31:51 UTC
Created attachment 1744813 [details]
verified.log

Comment 20 errata-xmlrpc 2021-05-18 15:18:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1748


Note You need to log in before you can comment on or make changes to this bug.