Bug 1908783 - prelude-inttypes.h includes config.h
Summary: prelude-inttypes.h includes config.h
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: libprelude
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Thomas Andrejak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-17 15:49 UTC by Steve Grubb
Modified: 2022-06-08 09:21 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-30 19:05:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Steve Grubb 2020-12-17 15:49:26 UTC
Description of problem:
/usr/include/libprelude/prelude-inttypes.h has the following code:

#ifdef HAVE_CONFIG_H
# include "config.h"
#endif

This is meant for when libprelude itself is compiled. This should not be in any header file installed for system use. This is because anything using autools will define HAVE_CONFIG_H, but how can this be meaningful to prelude when there is no idea what tests were done in the application being installed.

This code should be removed during the build of libprelude. If this file really needs some defines from when it was built, then it should be converted to prelude-inttypes.h.in and automake fill in the defines prior to starting the libprelude compile.

Building suricata-6.0 is blocked on this.

Version-Release number of selected component (if applicable):
libprelude-devel-5.2.0-1.fc33

Comment 1 Fedora Admin user for bugzilla script actions 2021-08-04 12:09:53 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 2 Gwyn Ciesla 2021-08-05 15:18:11 UTC
suricata 6.0.3 is in rawhide.

Comment 3 Steve Grubb 2021-08-05 15:41:47 UTC
Yes, but we had to comment out BuildRequires: libprelude-devel to get it to build. The code in comment 1 should only be for unshipped headers. Upstream has made some kind of mistake.

Comment 4 Gwyn Ciesla 2021-08-05 16:14:34 UTC
Ah, ok. So that section should be removed, or the whole header should be omitted?

Comment 5 Steve Grubb 2021-08-05 16:32:53 UTC
That should be removed. However, it begs the question of whether or not there are variables/defines or anything else that depends on something from the config.h when prelude was compiled? Usually this indicates that they might have wanted prelude-inttypes.h.in which gets updated by autoconf. I haven't looked too deeply at this issue, though. Maybe upstream has a fix?

Comment 6 Gwyn Ciesla 2021-08-05 16:36:13 UTC
"that" meaning the file or the section?

My search of the forum and issues came up empty.

Comment 7 Steve Grubb 2021-08-05 16:51:53 UTC
"That" meaning the 3 lines of code in comment #0.

Comment 8 Gwyn Ciesla 2021-08-05 17:45:50 UTC
Gotcha. See if 5.2.0-8 in rawhide fixes things.

Comment 9 Fedora Admin user for bugzilla script actions 2021-08-06 00:09:12 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 10 Fedora Admin user for bugzilla script actions 2021-08-14 00:06:37 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 11 Thomas Andrejak 2021-08-14 00:26:03 UTC
Hello

Is it fixed ?

Regards

Comment 12 Ben Cotton 2021-11-04 13:47:48 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 13 Ben Cotton 2021-11-04 14:17:16 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 14 Ben Cotton 2021-11-04 15:14:55 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Ben Cotton 2021-11-30 19:05:09 UTC
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 16 Istiak Ferdous 2022-06-08 08:52:10 UTC
Can't build Suricata for this bug in EPEL 9.

/usr/include/libprelude/common.h:28:11: fatal error: config.h: No such file or directory
   28 | # include "config.h"
      |           ^~~~~~~~~~

```
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif
```

Comment 17 Istiak Ferdous 2022-06-08 09:21:11 UTC
Currently following header files have this.

common.h
idmef-object.h
idmef-path.h
idmef-time.h
idmef.h
prelude-client-profile.h
prelude-error.h
prelude-extract.h
prelude-io.h
prelude-list.h
prelude-log.h
prelude-plugin.h
prelude-string.h
prelude-thread.h
prelude-timer.h


Note You need to log in before you can comment on or make changes to this bug.