Bug 1909287 - WALinuxAgent-udev: consider installing udev rules into initramfs
Summary: WALinuxAgent-udev: consider installing udev rules into initramfs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: WALinuxAgent
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly Kuznetsov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-18 20:15 UTC by Micah Abbott
Modified: 2023-06-22 13:09 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-06-22 13:09:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Micah Abbott 2020-12-18 20:15:02 UTC
For Fedora CoreOS (and RHCOS downstream), disk provisioning happens in the initramfs via Ignition.

Because the Azure udev rules in the `WALinuxAgent-udev` package are only installed as part of the real root, it may not be possible to provision additional disks during the Ignition stage in the initramfs.

Thus it would be useful if the `WALinuxAgent-udev` package would be able to install the rules into the initramfs.

See discussion on https://github.com/coreos/fedora-coreos-config/pull/786

Comment 1 Vitaly Kuznetsov 2021-01-04 10:54:46 UTC
At first glance putting these udev rules to initramfs shouldn't break anything
even when Ignition is not used. Also, it is possible to enable or disable the
suggested dracut module when needed. I'll try to put things together and see
how it goes, thanks for the suggestion!

Comment 2 Vitaly Kuznetsov 2021-01-15 14:27:14 UTC
Built WALinuxAgent-2.2.52-2.fc34 to rawhide and at first glance nothing seems
to be broken by the change. Please test!

Comment 3 Yuxin Sun 2021-01-19 10:11:08 UTC
Tier1 test of WALinuxAgent-2.2.52-2.el9.noarch.rpm has passed.

Comment 4 Ben Cotton 2021-11-04 16:16:56 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2021-11-30 17:44:41 UTC
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Dusty Mabe 2022-04-22 02:00:21 UTC
Hey Vitaly,

Would you consider this enhancement? Right now in Fedora CoreOS/RHCOS we are carrying glue code that gets these udev rules into the initramfs [1]. It would be nice if we didn't have to do that and could rely on an RPM for this.

[1] https://github.com/coreos/fedora-coreos-config/pull/786

Comment 7 Vitaly Kuznetsov 2022-04-22 06:35:52 UTC
(In reply to Dusty Mabe from comment #6)
> Hey Vitaly,
> 
> Would you consider this enhancement? Right now in Fedora CoreOS/RHCOS we are
> carrying glue code that gets these udev rules into the initramfs [1]. It
> would be nice if we didn't have to do that and could rely on an RPM for this.
> 
> [1] https://github.com/coreos/fedora-coreos-config/pull/786

Hm, this should be done already as of 

commit 521b67bc8575f53a30b4b2c4e63292e67483a4e1
Author: Vitaly Kuznetsov <vkuznets>
Date:   Fri Jan 15 14:27:07 2021 +0100

    Add udev rules to initramfs (#1909287)
 
it seems the BZ got stuck in ON_QA. Could you please verify that everything is
in place so we can close it? Thanks!

Comment 8 Dusty Mabe 2022-04-22 13:24:54 UTC
Thanks Vitaly,

Sorry for not reading the BZ comments more closely and recognizing the work had already been done.

I just removed our glue code [1] and the rules are still in place in the initramfs. I'd say this is verified (for my test it was WALinuxAgent-udev-2.3.1.1-2.fc35.noarch). 

We'll have tests that run on azure execute later today too.

Comment 9 Micah Abbott 2022-04-26 19:34:08 UTC
I think the change Dusty meant to reference was https://github.com/coreos/fedora-coreos-config/pull/1686

Comment 10 Ben Cotton 2022-08-09 13:42:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.


Note You need to log in before you can comment on or make changes to this bug.