Bug 1909461 - fedpkg clean no longer works
Summary: fedpkg clean no longer works
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fedpkg
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ondřej Nosek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-20 06:16 UTC by Ralf Corsepius
Modified: 2021-09-09 17:45 UTC (History)
6 users (show)

Fixed In Version: fedpkg-1.41-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-09 17:45:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ralf Corsepius 2020-12-20 06:16:27 UTC
Description of problem:

"fedpkg clean" doesn't any longer clean up *src.rpm and results_*

Additional info:
This behavior change renders "fedpkg clean" into a mostly useless hoax.

Comment 1 Ondřej Nosek 2021-01-27 22:12:55 UTC
Hello Ralf,

I got your point. There is a config in every cloned repository that prevents some file-types to be cleaned. This config is in ".git/info/exclude" in the cloned repository. For example /myrepos/fedpkg/.git/info/exclude. You can see the list of patters among where *src.rpm and results_* are by default. This exclude list is created when the repository is cloned and depends on fedpkg config value "git_excludes" in file /etc/rpkg/fedpkg.conf.
Just for your curiosity, the origin of this functionality can be found here: https://pagure.io/rpkg/issue/355

You have a couple of possibilities to customize fedpkg behaviour:

1) modify .git/info/exclude and remove unwanted patterns. This change is persistent for the repository. But other cloned repos will be still cloned with these patterns.

2) modify /etc/rpkg/fedpkg.conf and remove patterns there. In this case, additional modification of individual .git/info/excludes is needed (or new clone).

3) there is an argument for clean function, that can overcome exclude settings:

   fedpkg clean -x

   which means "Do not follow .gitignore rules". Unfortunately, this will obviously also remove already downloaded *.tar.gz sources listed in .gitexclude.

If you don't have other notes or requests about this issue, I would like to close this Bugzilla record.

Comment 2 Ondřej Nosek 2021-02-01 08:55:53 UTC
Description of the clean command was updated:
https://pagure.io/rpkg/pull-request/534

Comment 3 Fedora Update System 2021-08-25 10:26:45 UTC
FEDORA-EPEL-2021-4b1bb0ee48 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-4b1bb0ee48

Comment 4 Fedora Update System 2021-08-25 10:30:04 UTC
FEDORA-2021-20e5f8a6b8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

Comment 5 Fedora Update System 2021-08-25 20:50:50 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-20e5f8a6b8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-09-01 12:48:44 UTC
FEDORA-2021-20e5f8a6b8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

Comment 7 Fedora Update System 2021-09-01 20:21:09 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-20e5f8a6b8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-09-09 17:45:13 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.