Spec URL: ftp://ftp.bieringer.de/pub/tmp/vdr-extrecmenung.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3568/57853568/vdr-extrecmenung-2.0.5-1.fc33.src.rpm Description: This plugin provides a powerful replacement for VDR's default recordings menu entry. It looks like the standard recordings menu, but adds several functions, such as additional commands for "rename" and "move" This is the next generation version based on the original "extrecmenu" Fedora Account System Username: pbiering
I will take the review. $ rpmlint -v vdr-extrecmenung.spec /home/martin/rpmbuild/SRPMS/vdr-extrecmenung-2.0.5-1.fc33.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-extrecmenung-2.0.5-1.fc33.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-extrecmenung-debuginfo-2.0.5-1.fc33.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vdr-extrecmenung-debugsource-2.0.5-1.fc33.x86_64.rpm vdr-extrecmenung.spec: I: checking vdr-extrecmenung.spec: I: checking-url https://gitlab.com/kamel5/extrecmenung/-/archive/v2.0.5/extrecmenung-v2.0.5.tar.gz (timeout 10 seconds) vdr-extrecmenung.src: I: checking vdr-extrecmenung.src: W: spelling-error %description -l en_US extrecmenu -> extremeness vdr-extrecmenung.src: I: checking-url https://gitlab.com/kamel5/extrecmenung (timeout 10 seconds) vdr-extrecmenung.src: I: checking-url https://gitlab.com/kamel5/extrecmenung/-/archive/v2.0.5/extrecmenung-v2.0.5.tar.gz (timeout 10 seconds) vdr-extrecmenung.x86_64: I: checking vdr-extrecmenung.x86_64: W: spelling-error %description -l en_US extrecmenu -> extremeness vdr-extrecmenung.x86_64: I: checking-url https://gitlab.com/kamel5/extrecmenung (timeout 10 seconds) vdr-extrecmenung.x86_64: W: file-not-utf8 /usr/share/doc/vdr-extrecmenung/HISTORY vdr-extrecmenung-debuginfo.x86_64: I: checking vdr-extrecmenung-debuginfo.x86_64: I: checking-url https://gitlab.com/kamel5/extrecmenung (timeout 10 seconds) vdr-extrecmenung-debugsource.x86_64: I: checking vdr-extrecmenung-debugsource.x86_64: I: checking-url https://gitlab.com/kamel5/extrecmenung (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 3 warnings. please add to prep section: iconv -f iso-8859-1 -t utf-8 HISTORY > HISTORY.utf8 ; mv HISTORY.utf8 HISTORY
please remove %defattr - Drop %%defattr no longer needed with rpmbuild >= 4.4.
utf8: fixed defattr: fixed Spec URL(updated file): ftp://ftp.bieringer.de/pub/tmp/vdr-extrecmenung.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8622/58548622/vdr-extrecmenung-2.0.5-3.fc33.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "Unknown or generated". 70 files have unknown license. Detailed output of licensecheck in /home/martin/rpmbuild/SPECS/vdr- extrecmenung/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Sources can be downloaded from URI in Source: tag See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: vdr-extrecmenung-2.0.5-3.fc34.x86_64.rpm vdr-extrecmenung-debuginfo-2.0.5-3.fc34.x86_64.rpm vdr-extrecmenung-debugsource-2.0.5-3.fc34.x86_64.rpm vdr-extrecmenung-2.0.5-3.fc34.src.rpm vdr-extrecmenung.x86_64: W: spelling-error %description -l en_US extrecmenu -> extremeness vdr-extrecmenung.src: W: spelling-error %description -l en_US extrecmenu -> extremeness vdr-extrecmenung.src:47: W: macro-in-%changelog %defattr 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: vdr-extrecmenung-debuginfo-2.0.5-3.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- vdr-extrecmenung.x86_64: W: spelling-error %description -l en_US extrecmenu -> extremeness 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- vdr-extrecmenung (rpmlib, GLIBC filtered): config(vdr-extrecmenung) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) vdr(abi)(x86-64) vdr-extrecmenung-debuginfo (rpmlib, GLIBC filtered): vdr-extrecmenung-debugsource (rpmlib, GLIBC filtered): Provides -------- vdr-extrecmenung: config(vdr-extrecmenung) vdr-extrecmenung vdr-extrecmenung(x86-64) vdr-extrecmenung-debuginfo: debuginfo(build-id) vdr-extrecmenung-debuginfo vdr-extrecmenung-debuginfo(x86-64) vdr-extrecmenung-debugsource: vdr-extrecmenung-debugsource vdr-extrecmenung-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -rn ../SRPMS/vdr-extrecmenung-2.0.5-3.fc33.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: SugarActivity, Perl, Haskell, Java, R, Python, Ocaml, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH looks good to me, package approved
what are the next steps?
sorry, had forgotten what to do next...submitted now: fedpkg request-repo vdr-extrecmenung 1909468 https://pagure.io/releng/fedora-scm-requests/issue/31744
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vdr-extrecmenung
FEDORA-2021-44e99f2385 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-44e99f2385
FEDORA-2021-e965cd9142 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e965cd9142
FEDORA-2021-44e99f2385 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-44e99f2385 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-44e99f2385 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-e965cd9142 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e965cd9142 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e965cd9142 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-e316e5ea83 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e316e5ea83
FEDORA-2021-b42b6597e1 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b42b6597e1
FEDORA-2021-b42b6597e1 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b42b6597e1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b42b6597e1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-e316e5ea83 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e316e5ea83 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e316e5ea83 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-b42b6597e1 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-e316e5ea83 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.