Bug 1910857 - Provide a mechanism to enable the HotplugVolumes feature gate via HCO
Summary: Provide a mechanism to enable the HotplugVolumes feature gate via HCO
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Installation
Version: 2.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: 2.6.0
Assignee: Simone Tiraboschi
QA Contact: Inbar Rose
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-25 09:05 UTC by Yan Du
Modified: 2021-03-10 11:23 UTC (History)
7 users (show)

Fixed In Version: hco-bundle-registry-container-v2.6.0-454
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-10 11:22:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt hyperconverged-cluster-operator pull 1034 0 None closed Allow setting the 'HotplugVolumes' KV feature gate from HC CR 2021-01-27 11:28:14 UTC
Github kubevirt hyperconverged-cluster-operator pull 1036 0 None closed [release-1.3] Allow setting the 'HotplugVolumes' KV feature gate from HC CR 2021-01-27 11:28:14 UTC
Github kubevirt hyperconverged-cluster-operator pull 1060 0 None closed Change the FeatureGates implemantation 2021-01-27 11:28:14 UTC
Github kubevirt hyperconverged-cluster-operator pull 1062 0 None closed [Release 1.3] Change the FeatureGates implemantation (#1060) 2021-01-27 11:28:14 UTC
Red Hat Product Errata RHSA-2021:0799 0 None None None 2021-03-10 11:23:19 UTC

Description Yan Du 2020-12-25 09:05:06 UTC
Description of problem:


Version-Release number of selected component (if applicable):
Client Version: 4.7.0-202012220147.p0-8fbc95f
Server Version: 4.7.0-fc.0
Kubernetes Version: v1.20.0+87544c5
CNV 2.6.0


How reproducible:
Always


Steps to Reproduce:
1. $ oc get configmap kubevirt-config -o yaml -n openshift-cnv


Actual results:
$ oc get configmap kubevirt-config -o yaml -n openshift-cnv
apiVersion: v1
data:
  default-network-interface: masquerade
  feature-gates: DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Sidecar,Snapshot
  machine-type: pc-q35-rhel8.2.0
  selinuxLauncherType: virt_launcher.process
  smbios: |-
    Family: Red Hat
    Product: Container-native virtualization
    Manufacturer: Red Hat
    Sku: 2.6.0
    Version: 2.6.0
------------------8<-------------------

Expected results:
HotplugVolumes should be enabled in feature-gates

Additional info:

Comment 1 Ying Cui 2021-01-04 10:54:40 UTC
We would like to escalate this defect as it block us to test hotplug feature.

Comment 2 Alexander Wels 2021-01-04 13:13:33 UTC
For 2.6 the hotplug feature is still in alpha, so not enabled by default. You can enable it manually and it should work though

Comment 7 Yan Du 2021-01-15 08:15:28 UTC
Test on latest hco-bundle-registry-container-v2.6.0-454, HotplugVolumes feature gate could be enabled/disabled when setting the flag true/false in hco cr.

verify steps:
1. Enable the HotplugVolumes flag in hco cr
----------8<-----------
spec:
  bareMetalPlatform: true
  featureGates:
    HotplugVolumes: true
  infra: {}
  version: v2.6.0
  workloads: {}
----------8<-----------

2. Check the configmap 
$ oc get configmap kubevirt-config -o yaml -n openshift-cnv
apiVersion: v1
data:
  default-network-interface: masquerade
  feature-gates: DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Sidecar,Snapshot,HotplugVolumes

Comment 8 Nahshon Unna-Tsameret 2021-01-18 10:30:39 UTC
We had to change the feature gate implementation in HCO, in order to be able to get better documentation; see https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1060 and https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1062

That cause a small API change: "HotplugVolumes" was changed to "hotplugVolumes" (starts with lower case; to get a valid json/yaml tag)

Comment 9 Yan Du 2021-01-28 07:05:18 UTC
@Nahshon Unna-Tsameret  Thanks for letting us know

Comment 12 errata-xmlrpc 2021-03-10 11:22:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 2.6.0 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0799


Note You need to log in before you can comment on or make changes to this bug.