Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://scrye.com/~kevin/fedora/review/python-sgmllib3/python-sgmllib3.spec SRPM URL: https://scrye.com/~kevin/fedora/review/python-sgmllib3/python-sgmllib3k-1.0.0-1.fc34.src.rpm Description: sgmllib was dropped in Python 3. For those depending on it, that’s somewhat unfortunate. This is a quick and dirty port of this old module. I just ran 2to3 on it and published it. I don’t intend to maintain it, so it might be a good idea to eventually think about finding another module to use. Fedora Account System Username: kevin This package is needed for the new python-feedparser versions. I hope they will move to a more sustainable solution, but for now they are using this for sgmllib. rpmlint says: python3-sgmllib3k.noarch: W: spelling-error Summary(en_US) sgmllib -> SGML python3-sgmllib3k.noarch: W: summary-not-capitalized C python3 copy of sgmllib python3-sgmllib3k.noarch: W: spelling-error %description -l en_US sgmllib -> SGML python3-sgmllib3k.noarch: W: invalid-url URL: http://hg.hardcoded.net/sgmllib <urlopen error [Errno -2] Name or service not known> python-sgmllib3k.src: W: spelling-error Summary(en_US) sgmllib -> SGML python-sgmllib3k.src: W: summary-not-capitalized C python3 copy of sgmllib python-sgmllib3k.src: W: spelling-error %description -l en_US sgmllib -> SGML python-sgmllib3k.src: W: invalid-url URL: http://hg.hardcoded.net/sgmllib <urlopen error [Errno -2] Name or service not known> All bogus and can be ignored, IMHO.
The urls are wrong. There is a missing k after the 3 in the directory and also in the spec file name. Spec URL: https://scrye.com/~kevin/fedora/review/python-sgmllib3k/python-sgmllib3k.spec SRPM URL: https://scrye.com/~kevin/fedora/review/python-sgmllib3k/python-sgmllib3k-1.0.0-1.fc34.src.rpm Let us see if fedora-review accepts my correction. :-) Take 2 is coming.
Cool, fedora-review accepted the fix. :-) The license is correct and appropriated for Fedora. The spec file is simple and correct. fedora-review complains that: - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python3.9/site- packages/sgmllib.py See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Probably from %pycached %{python3_sitelib}/sgmllib.py? A minor point is that probably the line after "%install": rm -rf $RPM_BUILD_ROOT can be removed, as it is not required anymore, even in EPEL. I trust you to fix these on import. The package is approved.
Oops. Very sorry about the typo there. :( Will fix those things up! Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sgmllib3k
Built in rawhide.