Bug 1911270 - Create manila share with name = 'None' and without name argument is ambiguous
Summary: Create manila share with name = 'None' and without name argument is ambiguous
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-manilaclient
Version: 17.0 (Wallaby)
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: z4
: 17.1
Assignee: lkuchlan
QA Contact: lkuchlan
RHOS Documentation Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-28 12:55 UTC by lkuchlan
Modified: 2024-11-21 09:37 UTC (History)
10 users (show)

Fixed In Version: python-manilaclient-2.6.4-17.1.20240829230755.7f7d7d3.el9ost
Doc Type: Bug Fix
Doc Text:
Before this update, the Shared File Systems service (manila) shell client allowed users to name their shares with an invalid name. An invalid name, for example "None", conflicted with the notation that the service uses for fields that are not populated by the user or service. With this update, the client rejects invalid names for an improved user experience when creating shares with a custom name or filtering created shares by name.
Clone Of:
Environment:
Last Closed: 2024-11-21 09:37:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1909477 0 None None None 2020-12-28 13:31:19 UTC
OpenStack gerrit 768606 0 None MERGED Forbid users to create shares with the name "None" 2021-07-20 19:39:53 UTC
OpenStack gerrit 850143 0 None MERGED Avoid any capitalization of the name "None" 2023-08-16 13:59:49 UTC
Red Hat Issue Tracker OSP-2184 0 None None None 2021-11-18 14:25:43 UTC
Red Hat Product Errata RHBA-2024:9974 0 None None None 2024-11-21 09:37:58 UTC

Description lkuchlan 2020-12-28 12:55:47 UTC
Description of problem:
This is also true for manila snapshot creation

Version-Release number of selected component (if applicable):
python3-manilaclient-1.29.0-0.20200310223441.1b2cafb.el8ost.noarch

How reproducible:
100%

Steps to Reproduce:
(overcloud) [stack@undercloud-0 ~]$ manila create nfs 1
+---------------------------------------+--------------------------------------+
| Property                              | Value                                |
+---------------------------------------+--------------------------------------+
| id                                    | c1f4cd6c-803f-4288-83b3-c7f819e96969 |
| size                                  | 1                                    |
| availability_zone                     | None                                 |
| created_at                            | 2020-12-28T12:39:11.000000           |
| status                                | creating                             |
| name                                  | None                                 |
| description                           | None                                 |
| project_id                            | b87d77dda3714d6dbe912dd9617ed9ec     |
| snapshot_id                           | None                                 |
| share_network_id                      | None                                 |
| share_proto                           | NFS                                  |
| metadata                              | {}                                   |
| share_type                            | 5a7912d9-1836-44c7-ba74-75c1b8aba116 |
| is_public                             | False                                |
| snapshot_support                      | True                                 |
| task_state                            | None                                 |
| share_type_name                       | default                              |
| access_rules_status                   | active                               |
| replication_type                      | None                                 |
| has_replicas                          | False                                |
| user_id                               | 6600c821d28d41ce9e5e77eed7a5d412     |
| create_share_from_snapshot_support    | False                                |
| revert_to_snapshot_support            | False                                |
| share_group_id                        | None                                 |
| source_share_group_snapshot_member_id | None                                 |
| mount_snapshot_support                | False                                |
| share_server_id                       | None                                 |
| host                                  |                                      |
+---------------------------------------+--------------------------------------+

(overcloud) [stack@undercloud-0 ~]$ manila list
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+
| ID                                   | Name | Size | Share Proto | Status    | Is Public | Share Type Name | Host                    | Availability Zone |
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+
| c1f4cd6c-803f-4288-83b3-c7f819e96969 | None | 1    | NFS         | available | False     | default         | hostgroup@cephfs#cephfs | nova              |
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+

(overcloud) [stack@undercloud-0 ~]$ manila create nfs 1 --name None
+---------------------------------------+--------------------------------------+
| Property                              | Value                                |
+---------------------------------------+--------------------------------------+
| id                                    | b7efaa3e-9057-40a7-b3c6-f9190f269984 |
| size                                  | 1                                    |
| availability_zone                     | None                                 |
| created_at                            | 2020-12-28T12:39:30.000000           |
| status                                | creating                             |
| name                                  | None                                 |
| description                           | None                                 |
| project_id                            | b87d77dda3714d6dbe912dd9617ed9ec     |
| snapshot_id                           | None                                 |
| share_network_id                      | None                                 |
| share_proto                           | NFS                                  |
| metadata                              | {}                                   |
| share_type                            | 5a7912d9-1836-44c7-ba74-75c1b8aba116 |
| is_public                             | False                                |
| snapshot_support                      | True                                 |
| task_state                            | None                                 |
| share_type_name                       | default                              |
| access_rules_status                   | active                               |
| replication_type                      | None                                 |
| has_replicas                          | False                                |
| user_id                               | 6600c821d28d41ce9e5e77eed7a5d412     |
| create_share_from_snapshot_support    | False                                |
| revert_to_snapshot_support            | False                                |
| share_group_id                        | None                                 |
| source_share_group_snapshot_member_id | None                                 |
| mount_snapshot_support                | False                                |
| share_server_id                       | None                                 |
| host                                  |                                      |
+---------------------------------------+--------------------------------------+

(overcloud) [stack@undercloud-0 ~]$ manila list
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+
| ID                                   | Name | Size | Share Proto | Status    | Is Public | Share Type Name | Host                    | Availability Zone |
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+
| b7efaa3e-9057-40a7-b3c6-f9190f269984 | None | 1    | NFS         | available | False     | default         | hostgroup@cephfs#cephfs | nova              |
| c1f4cd6c-803f-4288-83b3-c7f819e96969 | None | 1    | NFS         | available | False     | default         | hostgroup@cephfs#cephfs | nova              |
+--------------------------------------+------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+

Comment 22 Lon Hohberger 2023-11-16 11:34:13 UTC
According to our records, this should be resolved by python-manilaclient-2.6.4-1.20220727212635.7f7d7d3.el9ost.  This build is available now.

Comment 23 Goutham Pacha Ravi 2024-01-03 19:32:25 UTC
(In reply to Lon Hohberger from comment #22)
> According to our records, this should be resolved by
> python-manilaclient-2.6.4-1.20220727212635.7f7d7d3.el9ost.  This build is
> available now.

Unfortunately not; the FIV is incorrect since https://review.opendev.org/c/openstack/python-manilaclient/+/850143 wasn't backported to stable/wallaby upstream. Dropping the FIV and re-targeting this BZ

Comment 31 lkuchlan 2024-10-27 11:10:47 UTC
Tested using:
python3-manilaclient-2.6.4-17.1.20240830140806.7f7d7d3.el9ost.noarch

Verification steps:
(overcloud) [stack@undercloud-0 ~]$ manila create nfs 1 --name none
ERROR: Share name cannot be with the value 'None'

Comment 36 errata-xmlrpc 2024-11-21 09:37:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (RHOSP 17.1.4 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:9974


Note You need to log in before you can comment on or make changes to this bug.