Bug 1911296 - Review Request: python-enrich - Enrich adds few missing features to the wonderful rich library
Summary: Review Request: python-enrich - Enrich adds few missing features to the wonde...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-28 15:28 UTC by chedi toueiti
Modified: 2022-07-13 14:17 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-07-13 14:17:25 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description chedi toueiti 2020-12-28 15:28:32 UTC
Spec URL: https://chedi.fedorapeople.org/python-enrich-1.2.6-1.fc33.src.rpm
SRPM URL: https://chedi.fedorapeople.org/python-enrich.spec
Description: Enrich adds few missing features to the wonderful rich library
Fedora Account System Username: chedi

Comment 1 José Matos 2021-01-03 17:06:03 UTC
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review has no complaint.

The only quirk that I found in the srpm is the description a bit confusing.
I suggest something like:

python-enrich extends the python rich library...

This can be fixed on import.
The package is approved.

Comment 2 chedi toueiti 2021-01-03 17:26:29 UTC
@José

First, thanks for taking the time to review this package. As for the description, I know it's a little bit 
confusing but the original pypi package name is simply enrich.

I think most fedora python package user are in the know that the package name starting with python?- 
rarely reflects the original pypi name.

Comment 3 Igor Raits 2021-01-03 17:46:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-enrich


Note You need to log in before you can comment on or make changes to this bug.