Spec URL: http://stingr.net/l/fe/pyserial.spec SRPM URL: http://stingr.net/l/fe/pyserial-2.2-1.src.rpm Description: This module capsulates the access for the serial port. It provides backends for standard Python running on Windows, Linux, BSD (possibly any POSIX compilant system) and Jython. The module named "serial" automaticaly selects the appropriate backend.
rpmlint SRPM results: W: pyserial invalid-license PSF - see LICENSE.txt E: pyserial no-cleaning-of-buildroot * Please use "Python license" for License. * Don't forget "rm -rf $RPM_BUILD_ROOT" as the first step of %install. rpmlint RPM results: W: pyserial invalid-license PSF - see LICENSE.txt W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/CHANGES.txt E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxTerminal.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/LICENSE.txt E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialposix.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialposix.py E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialwin32.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialwin32.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialwin32.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/scan.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxSerialConfigDialog.wxg E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/miniterm.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/setup_demo.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/tcp_serial_redirect.py E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/__init__.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/__init__.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/README.txt E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test_advanced.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxSerialConfigDialog.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test_high_load.py E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialutil.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialutil.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialutil.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/enhancedserial.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxTerminal.wxg E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialjava.py "jython" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialjava.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialjava.py * Most of the problems here are bad line endings. Perhaps you need to use a sed script or something to fix the endings on these files? * The other problem relates to the modules (.py files) having an interpreter line at the top. I suggest a patch to remove the #! lines from the top of each file. Also see: http://fedoraproject.org/wiki/Packaging/Python * In %description: do you mean "encapsulates" ? * You don't need Requires: python-abi ... * Include the .py and .pyc files only, but specify %ghost for the .pyo files I look forward to seeing your result !
For the problem with line endings, you might be able to get away with putting export UNZIP="-aa" in %prep before %setup -q This works because the archive contains only text files. But I would check carefully that the module continues to work correctly! (Even though a Python module should be safe.)
http://stingr.net/l/fe/pyserial.spec http://stingr.net/l/fe/pyserial-2.2-2.src.rpm
rpmlint results: E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialposix.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialwin32.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialwin32.py 0644 E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/__init__.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialutil.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialutil.py 0644 E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialjava.py "jython" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialjava.py 0644 These are harmless, I believe. These files are not really scripts. One more thing for the specfile: since you are building a noarch package, you don't need the %{!?python_sitearch... line. (Just python_sitelib.) Also, I don't think you should be doing export libdirname=%{_lib}. Take out these 3 lines, and you should be good.
http://stingr.net/l/fe/pyserial.spec http://stingr.net/l/fe/pyserial-2.2-3.src.rpm
Do you still need the libdirname in %build? Unless I'm confused, you shouldn't have it. Please remove it and I think I will be able to accept.
Sorry, fixed. http://stingr.net/l/fe/pyserial.spec http://stingr.net/l/fe/pyserial-2.2-4.src.rpm
This package appears to have been accepted, imported and built. This bug should be closed NEXTRELEASE. I am going to go ahead and do so. If I am in error, please reopen.