Bug 1911935 (materia-kde) - Review Request: materia-kde - Port of the popular GTK theme Materia for the Plasma 5 desktop
Summary: Review Request: materia-kde - Port of the popular GTK theme Materia for the P...
Keywords:
Status: CLOSED ERRATA
Alias: materia-kde
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-01 20:09 UTC by Robert-André Mauchin 🐧
Modified: 2021-01-12 02:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-01-12 01:31:09 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2021-01-01 20:09:58 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/materia-kde.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/materia-kde-20201222-1.fc34.src.rpm

Description:
This is a port of the popular GTK theme Materia for Plasma 5 desktop with a few additions and extras.  In this package you'll find:   - Aurorae Themes  - Konsole Color Schemes  - Kvantum Themes  - Plasma Color Schemes  - Plasma Desktop Themes  - Plasma Look-and-Feel Settings  - Wallpapers  - Yakuake Skins

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2021-01-01 20:13:41 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=58745857

Comment 2 José Matos 2021-01-02 10:34:34 UTC
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

I am confused with that remark since the there is no .desktop file...

So the package is approved.

Comment 3 Robert-André Mauchin 🐧 2021-01-02 13:15:03 UTC
There is desktop files

aurorae/themes/Materia/metadata.desktop
aurorae/themes/Materia-Dark/metadata.desktop
aurorae/themes/Materia-Light/metadata.desktop
plasma/desktoptheme/Materia/metadata.desktop
plasma/desktoptheme/Materia-Color/metadata.desktop
plasma/look-and-feel/com.github.varlesh.materia/metadata.desktop
plasma/look-and-feel/com.github.varlesh.materia-dark/metadata.desktop
plasma/look-and-feel/com.github.varlesh.materia-light/metadata.desktop
wallpapers/Materia/metadata.desktop

But none in /usr/share/applications so they don't needto be checked.

Thanks for the review.

Comment 4 Igor Raits 2021-01-03 09:31:06 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/materia-kde

Comment 5 Fedora Update System 2021-01-03 10:42:33 UTC
FEDORA-2021-305deedad6 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-305deedad6

Comment 6 Fedora Update System 2021-01-03 10:42:44 UTC
FEDORA-2021-6fb1547677 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6fb1547677

Comment 7 Fedora Update System 2021-01-04 01:54:19 UTC
FEDORA-2021-6fb1547677 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6fb1547677 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6fb1547677

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-01-04 01:58:09 UTC
FEDORA-2021-305deedad6 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-305deedad6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-305deedad6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-01-12 01:31:09 UTC
FEDORA-2021-305deedad6 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-01-12 02:16:50 UTC
FEDORA-2021-6fb1547677 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.