Bug 1912689 - ticket uses SHA-1
Summary: ticket uses SHA-1
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Python Library
Version: 4.4.4
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.4.6
: 4.4.6.5
Assignee: Yedidyah Bar David
QA Contact: Qin Yuan
URL:
Whiteboard:
Depends On:
Blocks: 1912687 1912691
TreeView+ depends on / blocked
 
Reported: 2021-01-05 08:17 UTC by Yedidyah Bar David
Modified: 2022-02-04 10:10 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine-4.4.6.5
Clone Of:
Environment:
Last Closed: 2021-05-05 05:36:22 UTC
oVirt Team: Integration
Embargoed:
pm-rhel: ovirt-4.4+
sbonazzo: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 112858 0 None MERGED pachaging: pythonlib: ticket: Add support for PSS/SHA256 2021-04-22 07:55:53 UTC

Description Yedidyah Bar David 2021-01-05 08:17:08 UTC
Description of problem:

The ticket.py module uses SHA-1 for signatures/verification.

This should be replaced with SHA-256.

It should be done in coordination with updating the equivalent java code, and users of both of them.

Comment 1 Qin Yuan 2021-04-27 13:10:57 UTC
Can this bug be verified according to https://bugzilla.redhat.com/show_bug.cgi?id=1912691#c2?

Comment 2 Yedidyah Bar David 2021-04-27 13:52:24 UTC
(In reply to Qin Yuan from comment #1)
> Can this bug be verified according to
> https://bugzilla.redhat.com/show_bug.cgi?id=1912691#c2?

I think so, yes.

I didn't check the changes for the other bug, which is for Java code.

For current bug, about the python code, we kept the option of using SHA-1 - we generate both SHA-1 and SHA-256, and for signature verification use SHA-256 if it's included, otherwise SHA-1.

We do want to remove SHA-1 eventually, but decided it's safer to not this these in a single step, but separate - add SHA-256 support in one version (current) and remove SHA-1 in a later version (the next one, likely). I now opened bug 1954041 to track this.

Comment 3 Qin Yuan 2021-04-28 07:08:00 UTC
Didi, thank you for your explanation.

Move this bug to VERIFIED according to comment #2 and https://bugzilla.redhat.com/show_bug.cgi?id=1912691#c2

Comment 4 Sandro Bonazzola 2021-05-05 05:36:22 UTC
This bugzilla is included in oVirt 4.4.6 release, published on May 4th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.