Bug 1913138 - Doc of virsh domrename needs to be updated
Summary: Doc of virsh domrename needs to be updated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.4
Assignee: Peter Krempa
QA Contact: Lili Zhu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-06 05:12 UTC by Lili Zhu
Modified: 2021-05-25 06:47 UTC (History)
5 users (show)

Fixed In Version: libvirt-7.0.0-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-25 06:46:31 UTC
Type: Bug
Target Upstream Version: 7.0.0
Embargoed:

Attachments (Terms of Use)

Description Lili Zhu 2021-01-06 05:12:02 UTC 
Description of problem:
Doc of virsh domrename needs to be updated

Version-Release number of selected component (if applicable):
libvirt-daemon-6.10.0-1.module+el8.4.0+8898+a84e86e1.x86_64

How reproducible:
100% 

Steps to Reproduce:
1. try to domrename a guest with snapshot
# virsh list --all
 Id   Name             State
---------------------------------
 5    avocado-vt-vm1   running

# virsh snapshot-create-as avocado-vt-vm1 s1 --memspec file=/tmp/mem,snapshot=external --diskspec vda,snapshot=external,file=/tmp/disk
Domain snapshot s1 created

# virsh destroy avocado-vt-vm1 
Domain avocado-vt-vm1 destroyed

# virsh domrename avocado-vt-vm1 new
Domain successfully renamed

# virsh start new 
Domain new started

# virsh list --all
 Id   Name      State
--------------------------
 6    new       running

2. check the doc of domrename
domrename
       Syntax:

          domrename domain new-name

       Rename a domain. This command changes current domain name to the new name specified in the second argument.

       Note: Domain must be inactive and without snapshots or checkpoints.


Actual results:
Doc of virsh domrename needs to be updated
Comment 1 Peter Krempa 2021-01-06 10:52:57 UTC 
commit ec554e160b44aed0adac0256c2ad58153b638bae 
Author: Peter Krempa <pkrempa>
Date:   Wed Jan 6 10:56:12 2021 +0100

    manpage: virsh: Drop note that 'domrename' doesn't work with snapshots/checkpoints
    
    As of commits 3b1244bffdb and 4770a96c662 renaming of the domain works
    also with checkpoints and snapshots. Update the docs.

v6.10.0-311-gec554e160b
Comment 3 Lili Zhu 2021-01-11 08:33:20 UTC 
➜  ~ man virsh
...
domrename
       Syntax:

          domrename domain new-name

       Rename a domain. This command changes current domain name to the new name specified in the second argument.

       Note: Domain must be inactive.
...

Doc of virsh domrename has been updated
Comment 4 Lili Zhu 2021-01-11 08:34:25 UTC 
Testing in Comment 3 used libvirt-6.10.0-1.fc34.x86_64
Comment 7 Lili Zhu 2021-01-21 02:40:53 UTC 
Tested with:
libvirt-daemon-7.0.0-1.module+el8.4.0+9464+3e71831a.x86_64

Testing result are the same with that in Comment #3, mark the bug as verified.
Comment 9 errata-xmlrpc 2021-05-25 06:46:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:av bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2098
Note You need to log in before you can comment on or make changes to this bug.