Bug 1913382 - Review Request: rust-spin_on - Simple, inefficient Future executor
Summary: Review Request: rust-spin_on - Simple, inefficient Future executor
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1913384
TreeView+ depends on / blocked
 
Reported: 2021-01-06 15:55 UTC by Fabio Valentini
Modified: 2021-01-06 21:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-06 21:05:00 UTC
Type: ---
Embargoed:
igor.raits: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2021-01-06 15:55:08 UTC 
Spec URL: https://decathorpe.fedorapeople.org/packages/rust-spin_on.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-spin_on-0.1.1-1.fc33.src.rpm

Description:
Simple, inefficient Future executor

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=59064733
Comment 1 Igor Raits 2021-01-06 19:48:04 UTC 
> %exclude %{cargo_registry}/%{crate}-%{version_no_tilde}/Makefile.toml

Instead of excluding it this way, please create a PR to upstream and patch Cargo.toml instead.
Comment 2 Fabio Valentini 2021-01-06 20:06:43 UTC 
(In reply to Igor Raits from comment #1)
> > %exclude %{cargo_registry}/%{crate}-%{version_no_tilde}/Makefile.toml
> 
> Instead of excluding it this way, please create a PR to upstream and patch
> Cargo.toml instead.

Will do.
Comment 3 Gwyn Ciesla 2021-01-06 20:17:14 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-spin_on
Comment 4 Fabio Valentini 2021-01-06 21:05:00 UTC 
Exclude moved to Cargo.toml patch, PR submitted upstream.

Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1665878
Note You need to log in before you can comment on or make changes to this bug.