Bug 1913387
| Summary: | [CBT] [RFE] Extend backup scratch disk as needed | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Nir Soffer <nsoffer> |
| Component: | Core | Assignee: | Nir Soffer <nsoffer> |
| Status: | CLOSED WONTFIX | QA Contact: | Evelina Shames <eshames> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.40.40 | CC: | aefrat, ahadas, bugs, eshames, jean-louis, md, yisun, Yury.Panchenko |
| Target Milestone: | --- | Keywords: | FutureFeature, ZStream |
| Target Release: | --- | Flags: | sbonazzo:
ovirt-4.5-
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-03-16 12:51:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1913315, 2017928 | ||
| Bug Blocks: | 1913389 | ||
|
Description
Nir Soffer
2021-01-06 16:02:02 UTC
I think this is a major issue currently and causing incremental backups to be useless at this moment. Cause if you are on oVirt 4.4.5 (which already uses scratch disks) but without this, you end up with pauzed VM's as the scratch disk is never extended. Shouldn't we create scratch disks with size == disk size instead of thin provision them until this is fixed? Its not an ideal situation as you might need much more storage, but the current situation is even worse I think. (In reply to Jean-Louis Dupond from comment #1) > Shouldn't we create scratch disks with size == disk size instead of thin > provision them until this is fixed? This is what we do now - we create thin disk with initial size equal equal to the original disk virtual size. When the disk is created, you should be able to see the initial_size= argument, it must be the virtual size of the original disk. This will allocated logical volume of virtual size * 1.1 on storage, and create a qcow2 image on this logical volume. If this is not the case, this is a bug. I don't know what's the ETA is for oVirt 4.5.0, but I think this bug deserves some more priority :) The biggest issue now is that if you do concurrent incremental backups, you really need a ton of additional diskspace on your iSCSI LUN. Take you backup 2 500G VM's, you need an additional 1TB extra free diskapace to be able to backup them. This is a huge blocker to start using incremental backups in production. Also ain't most of the work already done by Nir? (In reply to Jean-Louis Dupond from comment #3) > I don't know what's the ETA is for oVirt 4.5.0, but I think this bug > deserves some more priority :) > > The biggest issue now is that if you do concurrent incremental backups, you > really need a ton of additional diskspace on your iSCSI LUN. > Take you backup 2 500G VM's, you need an additional 1TB extra free diskapace > to be able to backup them. > This is a huge blocker to start using incremental backups in production. > > Also ain't most of the work already done by Nir? You are right and this feature is under development. There is still much work to do but this one should be delivered in oVirt 4.5. Nir, do we miss anything for this bz? Yes, finish the work. The merged patches are just preparation for the actual work. ah wow, that's a lot of preparation patches :) ok, thanks *** Bug 2043175 has been marked as a duplicate of this bug. *** We took a different approach for backups that renders this bz redundant (as the new method doesn't involve using scratch disks). This new method will be available for testing as from oVirt 4.5 alpha (see bz 2053669) |