Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.src.rpm Description: Ansible modules to manage Koji resources. Fedora Account System Username: ignatenkobrain
Taking this review.
The packaging is mostly fine, except for some rpmlint issues, according to fedora-review: Rpmlint ------- Checking: ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.noarch.rpm ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.src.rpm ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_archivetype.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_btype.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_call.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_cg.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_external_repo.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_host.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag_inheritance.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag_packages.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_target.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_user.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url} 2 packages and 0 specfiles checked; 11 errors, 2 warnings.
New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.src.rpm
> ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} > ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url} Not something I can fix :) They are part of the ansible. --- I've fixed others.
(In reply to Igor Raits from comment #4) > > ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} > > ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url} > > Not something I can fix :) They are part of the ansible. > Then don't use that macro and put something useful. File a bug upstream about the broken metadata if that's the cause.
> Then don't use that macro and put something useful. File a bug upstream about the broken metadata if that's the cause. There is no broken metadata. This macro is defined in Ansible and it works fine as long as you have Ansible installed.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
> BuildRequires: ansible This needs to be "BuildRequires: ansible-packaging" now.
I'm waiting on the packager...
New SPEC: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible.spec New SRPM: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdreyer-koji_ansible-0.0.450-1.fc37.src.rpm
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.