Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-1.src.rpm Description: XArchon is a chess with a twist board game. It is modelled after the golden oldie Archon game created by Freefall Associates.
MUST ==== * rpmlint output clean * Sources match upstream 491dea5b4e61ed13cd988d1c184a8ef0 xarchon-0.50.tar.gz * GPL license ok, license file included * Package and spec file named appropriately * .desktop file installed correctly * RPM_BUILD_ROOT cleaned appropriately * spec file is legible and in Am. English * No locales * No shared libs * No -devel subpackage needed * No -docs subpackage needed * Not relocatable * Owns all directories that it creates * Builds fine in mock on FC-4-i386 MUSTFIX ======= * Macro use isn't consistent. 'xarchon' is used in some places, while %{name} is used in others. SHOULD ====== * Don't bother including the NEWS file, it just tells the user to read the ChangeLog file. * Missing BR: libXpm-devel on FC-5.
(In reply to comment #1) > MUSTFIX > ======= > * Macro use isn't consistent. 'xarchon' is used in some places, while > %{name} is used in others. > Fixed > SHOULD > ====== > * Don't bother including the NEWS file, it just tells the user to read > the ChangeLog file. > Done > * Missing BR: libXpm-devel on FC-5. > Added (for -devel too) New version: Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-2.src.rpm
Nit: hardcoded .gz man page suffix
I always use a harcoded .gz for the manpage suffix. I try to use as little wildcards as possible in my %files sections. If a newer upstream versions installs new files I want to know. I've seen people do %{_bindir}/* %{_mandir}/man6/* etc, which IMHO is not a good idea. I know that the compressing sometimes is done by rpmbuild and the manpage's are installed uncompressed by make install, but AFAIK now a days they always end up being compressed.
All MUST and SHOULD items addressed. Runs without crashing (though I didn't test it extensively). APPROVED
Thanks! I would like todo something back but Chris has taken all your reviews sofar :) Imported and Build.
#187392? :)