Bug 191452 - Review Request: orpie - scientific calculator
Summary: Review Request: orpie - scientific calculator
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-12 04:41 UTC by Chris Petersen
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-20 00:07:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Petersen 2006-05-12 04:41:08 UTC
Spec URL: http://forevermore.net/files/packages/orpie/orpie.spec
SRPM URL: http://forevermore.net/files/packages/orpie/orpie-1.4.3-1.src.rpm

Description: 

Orpie is a fullscreen console-based RPN calculator that uses the curses
library.  Its operation is similar to that of modern HP calculators, but data
entry has been optimized for efficiency on a PC keyboard. Its features include
extensive scientific calculator functionality, command completion, and a
visible interactive stack.

Comment 1 Aurelien Bompard 2006-05-14 17:22:52 UTC
Needs work:
"Requires: ncurses" is useless, it's picked-up by RPM (libncurses.so.5)


Comment 2 Chris Petersen 2006-05-14 17:36:17 UTC
fixed.

Comment 3 Aurelien Bompard 2006-05-14 18:31:25 UTC
Review for release 1:
* RPM name is OK
* Source orpie-1.4.3.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine

Minor:
* Duplicate BuildRequires: ocaml (by camlp4)

Notes:
Always increment the release tag when you change something in the package, even
during the review process. It makes it easier to know what has been approved.


Comment 4 Chris Petersen 2006-05-15 03:44:53 UTC
Spec updated..  new srpm at:

http://forevermore.net/files/packages/orpie/orpie-1.4.3-3.src.rpm

Comment 5 Aurelien Bompard 2006-05-20 06:54:54 UTC
The only change is the release bump and the removal of BuildRequires: ocaml, so
release 3 is still APPROVED. You can go ahead and import, good work.


Note You need to log in before you can comment on or make changes to this bug.