Bug 1914676 (rust-notify-rust) - Review Request: rust-notify-rust - Show desktop notifications (linux, bsd, mac)
Summary: Review Request: rust-notify-rust - Show desktop notifications (linux, bsd, mac)
Keywords:
Status: CLOSED RAWHIDE
Alias: rust-notify-rust
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1900220
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-10 19:12 UTC by Igor Raits
Modified: 2021-01-11 07:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-11 07:54:55 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2021-01-10 19:12:29 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-notify-rust.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-notify-rust-4.2.2-1.fc34.src.rpm
Description:
Show desktop notifications (linux, bsd, mac). Pure Rust dbus client and server.
Fedora Account System Username: ignatenkobrain

Comment 1 Fabio Valentini 2021-01-10 20:13:15 UTC
     Running `/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/realworld-fa4f3f5c37d32eb8`
running 8 tests
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:32
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:142
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
test realworld::build_pattern ... ok
test realworld::burst ... FAILED
test realworld::category ... FAILED
test realworld::capabilities ... FAILED
test realworld::persistent ... FAILED
test realworld::init ... FAILED
test realworld::closing ... FAILED
test realworld::urgency ... FAILED
failures:
failures:
    realworld::burst
    realworld::capabilities
    realworld::category
    realworld::closing
    realworld::init
    realworld::persistent
    realworld::urgency
test result: FAILED. 1 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:57
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:64
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:154
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:105
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error { kind: Dbus(D-Bus error: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 (org.freedesktop.DBus.Error.NotSupported)) }
Location: tests/realworld.rs:129
Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
   Doc-tests notify-rust
     Running `/usr/bin/rustdoc --edition=2018 --crate-type lib --test /builddir/build/BUILD/notify-rust-4.2.2/src/lib.rs --crate-name notify_rust -L dependency=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps -L dependency=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps -L native=/usr/lib64 --cfg 'feature="dbus"' --cfg 'feature="default"' --cfg 'feature="d"' --extern color_backtrace=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/libcolor_backtrace-afc764df7ac8f4d8.rlib --extern ctor=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/libctor-9a8334aca45b6db3.so --extern dbus=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/libdbus-c25ce149f5f7100b.rlib --extern maplit=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/libmaplit-1dfd4ef974d823e9.rlib --extern notify_rust=/builddir/build/BUILD/notify-rust-4.2.2/target/release/deps/libnotify_rust-bd373d570ed324b4.rlib -C embed-bitcode=no`
running 11 tests
test src/lib.rs - (line 124) ... ignored
test src/lib.rs - (line 71) ... ok
test src/notification.rs - notification::Notification (line 32) ... ok
test src/notification.rs - notification::Notification::hint (line 217) ... ok
test src/urgency.rs - urgency::Urgency (line 16) ... ok
test src/xdg/mod.rs - xdg::NotificationHandle::close (line 79) ... ok
test src/lib.rs - (line 31) ... ok
test src/lib.rs - (line 19) ... ok
test src/xdg/mod.rs - xdg::NotificationHandle::on_close (line 103) ... ok
test src/lib.rs - (line 49) ... ok
test src/xdg/mod.rs - xdg::NotificationHandle::update (line 134) ... ok
test result: ok. 10 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--test realworld'

Looks like you'll need to use `%cargo_test -- -- --skip realworld`.

Comment 4 Fabio Valentini 2021-01-10 22:12:09 UTC
Package generated with rust2rpm, simplifying review.

- Package conforms to (Rust) Packaging Guidelines
- License matches upstream, PR to include it in published sources submitted
- Package builds and installs without errors on rawhide
- Latest version is packaged
- Patches are justified
- Excluded tests are justified

Please exclude .gitignore file from the -devel subpackage:
rust-notify-rust-devel.noarch: E: version-control-internal-file /usr/share/cargo/registry/notify-rust-4.2.2/.gitignore
(I see this too will be fixed upstream once the License PR is merged.)

Other than that, package APPROVED.

Comment 5 Igor Raits 2021-01-10 22:17:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-notify-rust


Note You need to log in before you can comment on or make changes to this bug.