Description of problem: NooBaa metrics start with NooBaa_ prefix. There has to be created duplicate metric with noobaa_ prefix in order to work with telemetry. Is it possible to accept metrics with names that include uppercase letters? For more information: https://bugzilla.redhat.com/show_bug.cgi?id=1893713#c3 Version-Release number of selected component (if applicable): 4.6.0-0.nightly-2020-12-14-142858 ocs-operator.v4.6.0-149.ci
This does not look like a bug to me. Telemeter _does_ support metrics with uppercase letters in the names. It just so happens that all of the NooBaa metrics collected by telemeter are collected with a lower-case name. You can see all of the metrics here: https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster-monitoring-operator_04-config.yaml#L208-L221 You mention in this issue (https://bugzilla.redhat.com/show_bug.cgi?id=1893713#c3) that there are duplicate metrics, however as far as I can tell, there are no metrics at all in Telemeter that start with NooBaa, e.g. NooBaa_total_usage. Check for yourself: https://infogw-data.api.openshift.com/graph?g0.expr=NooBaa_total_usage&g0.tab=1&g0.stacked=0&g0.range_input=1h&g0.max_source_resolution=0s&g0.deduplicate=1&g0.partial_response=0&g0.store_matches=%5B%5D So, in summary: 1 Telemeter _can_ collect metrics with uppercase letters; and 2 there are no duplicate NooBaa metrics I think we can close this.
Re-reading the context I think I understand better what the request here was. Telemeter does not mandate anywhere that metric names must be lower case. It is simply the convention for Prometheus metrics. If you really do want all NooBaa metrics to be uppercase, then you need to modify the client-side allow list here https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster-monitoring-operator_04-config.yaml#L208-L221 to collect the uppercase metrics and then modify the server-side allow list here https://github.com/rhobs/configuration/blob/main/resources/services/telemeter-template.yaml#L149-L151.
Yet, we highly advise to NOT send upper case metrics. Essentially those inconsistencies on names can cause surprises on many levels: user while querying for it, alerting when things are not alerted on because of human mistake assuming different case and storage itself sorting those series differently (upper vs lower case). Can we keep it lower case? (:
Hey Bartek, I think this can be closed? Assigning to you for final action. TY!
OpenShift has moved to Jira for its defect tracking! This bug can now be found in the OCPBUGS project in Jira. https://issues.redhat.com/browse/OCPBUGS-8832