Bug 1915818 - vsphere-problem-detector: use "_totals" in metrics
Summary: vsphere-problem-detector: use "_totals" in metrics
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.7.0
Assignee: Jan Safranek
QA Contact: Qin Ping
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-13 13:26 UTC by Jan Safranek
Modified: 2021-02-24 15:53 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:52:44 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift vsphere-problem-detector pull 20 0 None closed Bug 1915818: Add "total" suffix to counter metrics 2021-01-27 09:47:39 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:53:00 UTC

Description Jan Safranek 2021-01-13 13:26:52 UTC 
According to metrics naming rules specified in https://prometheus.io/docs/practices/naming/, a name of counter-style metric should have suffix "_total".

These metrics are therefore wrong and should get additional "_total" suffix:: vsphere_cluster_check_errors, vsphere_node_check_errors
Comment 2 Qin Ping 2021-01-14 05:17:33 UTC 
Verified with: 4.7.0-0.nightly-2021-01-14-040200
Comment 5 errata-xmlrpc 2021-02-24 15:52:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633
Note You need to log in before you can comment on or make changes to this bug.