Bug 1916041 - Review Request: rubygem-xmlrpc - XMLRPC is a lightweight protocol that enables remote procedure calls over HTTP
Summary: Review Request: rubygem-xmlrpc - XMLRPC is a lightweight protocol that enable...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: František Dvořák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1914516
TreeView+ depends on / blocked
 
Reported: 2021-01-14 01:45 UTC by Pavel Valena
Modified: 2021-06-15 12:40 UTC (History)
4 users (show)

Fixed In Version: rubygem-xmlrpc-0.3.2-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-15 12:40:56 UTC
Type: ---
Embargoed:
valtri: fedora-review+


Attachments (Terms of Use)

Description Pavel Valena 2021-01-14 01:45:29 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01879395-rubygem-xmlrpc/rubygem-xmlrpc.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01879395-rubygem-xmlrpc/rubygem-xmlrpc-0.3.1-1.1.fc34.src.rpm
(I do not intend to keep the additional `.1`, it's just to have permanent COPR build.)

Description: XMLRPC is a lightweight protocol that enables remote procedure calls over HTTP.

Fedora Account System Username: pvalena

COPR build: https://copr.fedorainfracloud.org/coprs/build/1878441
Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=59577803

Checks:

  - Koji build: ok
  - Tests: ok
  - Syntax check: ok
  - Reverse dependencies: ok
  - Smoke test: ok
  - rpmlint: ok

Comment 1 Vít Ondruch 2021-01-14 08:40:42 UTC
Could you please elaborate why is this needed?

Comment 2 Pavel Valena 2021-01-15 23:03:40 UTC
We use XMLRPC for Bughunting (not in Fedora yet), but xmlrpc was removed from Ruby.

Comment 3 František Dvořák 2021-02-15 16:45:56 UTC
It is also used as dependency in opennebula gem. Taking the review.

Comment 4 František Dvořák 2021-02-15 16:54:36 UTC
Issues:
=======
- license: it should be probably "Ruby or BSD"?
- there has been release 0.3.2 in the meantime (it's good the new dependency on 'webrick' has been recently packaged in Fedora :-))


Notes:
======
- the different version in changelog - but that's probably just due to the workflow with "-1.1" version in COPR?

Comment 5 Pavel Valena 2021-05-04 17:49:54 UTC
(In reply to František Dvořák from comment #4)

Firstly, thanks for review!

> Issues:
> =======
> - license: it should be probably "Ruby or BSD"?

Yes, you're right. Same as Ruby.
  https://github.com/ruby/xmlrpc/blob/master/LICENSE.txt

> - there has been release 0.3.2 in the meantime (it's good the new dependency
> on 'webrick' has been recently packaged in Fedora :-))

Sure, I'll bump the version.

> 
> 
> Notes:
> ======
> - the different version in changelog - but that's probably just due to the
> workflow with "-1.1" version in COPR?

Yes, this is a COPR thing, as you can have only one NVR available (new builds+specfiles+srpms with same NVR are removed). This ensures I can have persistent (latest) build available for the URL. It will be removed for the Fedora spec file.

_ _ _ _

I've updated the spec file and moved the result here:
  https://github.com/fedora-distgit/rubygem-xmlrpc/blob/rawhide/rubygem-xmlrpc.spec

I've also re-run the builds+tests:
  https://git.io/J3VmE

Comment 6 František Dvořák 2021-05-11 15:27:12 UTC
Thank you. Approved!

Comment 7 Gerald Cox 2021-06-13 19:07:08 UTC
Has this been pushed to the F34 repo?  I don't see it in koji.  I believe it is now needed for aria2rpc.  Thanks!

Comment 8 Pavel Valena 2021-06-14 09:50:54 UTC
You're right, I haven't built it yet. I think I can build this for F34 as well.

Comment 9 Gwyn Ciesla 2021-06-14 13:21:50 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-xmlrpc


Note You need to log in before you can comment on or make changes to this bug.