Bug 191606 - Review Request: lineak-kdeplugins - KDE-based actions for lineakd
Summary: Review Request: lineak-kdeplugins - KDE-based actions for lineakd
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On: 191604
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-13 19:44 UTC by Chris Petersen
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-06-03 09:19:04 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

Description Chris Petersen 2006-05-13 19:44:53 UTC
Spec URL: http://forevermore.net/files/packages/lineak/lineak_kdeplugins.spec
SRPM URL: http://forevermore.net/files/packages/lineak/lineak_kdeplugins-0.8.4-1.src.rpm
Description: 

Plugin for lineakd to support KDE and many of its applications.

Comment 2 Chris Petersen 2006-05-21 08:41:18 UTC
Shuffling files around on my server, and making a few changes to bring things up
to par.

http://rpm.forevermore.net/lineak/lineak_kdeplugins.spec
http://rpm.forevermore.net/lineak/lineak_kdeplugins-0.8.4-2.src.rpm

Comment 5 Jason Tibbitts 2006-06-01 19:05:25 UTC
Oddly, if you run rpmlint on the src.rpm, it complains about /lib being
hardcoded; I guess it just does a search for "/lib" and finds your call to sed.

Other than that, rpmlint is silent.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   4ddfc475e4df27f8822e0b08c0f701b5  lineak_kdeplugins-0.8.4.tar.gz
   4ddfc475e4df27f8822e0b08c0f701b5  lineak_kdeplugins-0.8.4.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
 final provides and requires are sane:
   amarokplugin.so()(64bit)
   jukplugin.so()(64bit)
   kdesktopplugin.so()(64bit)
   kmailplugin.so()(64bit)
   kmixplugin.so()(64bit)
   konqplugin.so()(64bit)
   kscdplugin.so()(64bit)
   lineak_kdeplugins = 0.8.4
   lineak-kdeplugins = 0.8.4-4.fc6
  -
   kdelibs
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libdl.so.2()(64bit)
   libgcc_s.so.1()(64bit)
   libkdecore.so.4()(64bit)
   libkdeui.so.4()(64bit)
   libkio.so.4()(64bit)
   liblineak.so.0()(64bit)
   libm.so.6()(64bit)
   libpng12.so.0()(64bit)
   libpthread.so.0()(64bit)
   libqt-mt.so.3()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libz.so.1()(64bit)
   lineakd = 0.8.4
* shared libraries are present, but internal to lineakd so no need to call ldconfig.
* package is not relocatable.
* owns the directories it creates (the plugins directory is created by lineakd,
which is a dependency).
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED


Note You need to log in before you can comment on or make changes to this bug.