Red Hat Bugzilla – Bug 191619
Review Request: perl-CSS-Tiny - Read/Write .css files with as little code as possible
Last modified: 2007-11-30 17:11:32 EST
CSS::Tiny is a perl class to read and write .css stylesheets with as
little code as possible, reducing load time and memory overhead.
Everything looks good; the only thing I question is the reason for including
test.css as %doc. It seems a bit pointless to me, but I guess it doesn't hurt
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible. License text is included in the package.
* source files match upstream:
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=4, Tests=47, 0 wallclock secs ( 0.14 cusr + 0.06 csys = 0.20 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
(In reply to comment #1)
> Everything looks good; the only thing I question is the reason for including
> test.css as %doc. It seems a bit pointless to me, but I guess it doesn't hurt
Indeed. I could swear it was a CSS example with more juicy. I will remove next
Imported and built for FC-5 and devel.