Spec URL: https://www.techie.net/~talbert/python-pyqt5-sip.spec SRPM URL: https://www.techie.net/~talbert/python-pyqt5-sip-12.8.1-1.fc35.src.rpm Description: The sip extension module provides support for the PyQt5 package. Fedora Account System Username: swt2c This is the PyQt5.sip Python module that's needed by PyQt5 when building with sip 5. This used to be provided by the 'sip' package in Fedora, but upstream has broken it out into a separate package.
> This is the PyQt5.sip Python module that's needed by PyQt5 when building with sip 5 This is actually a better description of the package than the Description in the package: > The sip extension module provides support for the PyQt5 package. The relationship between qt5 and sip is confusing... at least to me, but I assume I'm not alone. Can you add some explanation in the description?
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > This is the PyQt5.sip Python module that's needed by PyQt5 when building with sip 5 > > This is actually a better description of the package than the Description in > the package: > > > The sip extension module provides support for the PyQt5 package. > > The relationship between qt5 and sip is confusing... at least to me, but I > assume I'm > not alone. Can you add some explanation in the description? Yes, it is unfortunately confusing. Sip is a set of tools for creating Python bindings for C/C++ libraries and is the system that is used for generating the Python bindings for Qt (aka PyQt). The PyQt5.sip module is some helper code provided by sip that helps bindings users (PyQt) access some of the underlying sip features. Please hold off for now on reviewing this package as I'm wavering about whether we should package this separately (vice having the python-qt5 package build these itself, which is possible now with sip 5).
> Please hold off for now on reviewing this package as I'm wavering about whether we should package this separately (vice having the python-qt5 package build these itself, which is possible now with sip 5). Did you decide?
No, but I'll close this for now.
I'll review this.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed [ ] - nit pick/not blocking. A number of the source files have a comment: * This copy of SIP may also used under the terms of the GNU General Public * License v2 or v3 as published by the Free Software Foundation which can be * found in the files LICENSE-GPL2 and LICENSE-GPL3 included in this package. But there's no LICENSE-GPL2/LICENSE-GPL3. Might ask upstream to really include them here. I don't see any other issues, so this package is APPROVED. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2". 9 files have unknown license. Detailed output of licensecheck in /home/kevin/1916518-python-pyqt5-sip/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.10/site- packages/PyQt5(python3-qt5-base, python3-pyqt5-sip) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pyqt5-sip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- python3-pyqt5-sip: /usr/lib64/python3.10/site-packages/PyQt5/sip.cpython-310-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/P/PyQt5_sip/PyQt5_sip-12.8.1.tar.gz : CHECKSUM(SHA256) this package : 30e944db9abee9cc757aea16906d4198129558533eb7fadbe48c5da2bd18e0bd CHECKSUM(SHA256) upstream package : 30e944db9abee9cc757aea16906d4198129558533eb7fadbe48c5da2bd18e0bd Requires -------- python3-pyqt5-sip (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python-pyqt5-sip-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-pyqt5-sip: python-pyqt5-sip python3-pyqt5-sip python3-pyqt5-sip(x86-64) python3-sip-api(12) python3-sip-api(12)(x86-64) python3.10-pyqt5-sip python3.10dist(pyqt5-sip) python3dist(pyqt5-sip) python-pyqt5-sip-debugsource: python-pyqt5-sip-debugsource python-pyqt5-sip-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1916518 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python, C/C++ Disabled plugins: fonts, Haskell, Perl, SugarActivity, Java, PHP, R, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyqt5-sip