RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1917269 - vtysh running-config output not showing bgp ttl-security hops option
Summary: vtysh running-config output not showing bgp ttl-security hops option
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: frr
Version: 8.3
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: rc
: 8.0
Assignee: Michal Ruprich
QA Contact: František Hrdina
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-18 08:42 UTC by Carlos Goncalves
Modified: 2022-05-10 13:58 UTC (History)
3 users (show)

Fixed In Version: frr-7.5-6.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-10 13:36:44 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch (1.56 KB, patch)
2021-06-10 08:51 UTC, Michal Ruprich
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Github FRRouting frr issues 7848 0 None closed vtysh running-config output not showing bgp ttl-security hops option 2021-01-25 11:06:29 UTC
Github FRRouting frr pull 7873 0 None closed bgpd: Allow peer-groups to have `ttl-security hops` configured 2021-01-25 11:06:29 UTC
Red Hat Product Errata RHBA-2022:1778 0 None None None 2022-05-10 13:36:59 UTC

Description Carlos Goncalves 2021-01-18 08:42:11 UTC
BGP configuration option neighbor PEER ttl-security hops NUMBER not displayed in vtysh show running-config output.

Although the configuration is not displayed, it is being set per the BGP daemon log:
2021/01/11 14:56:26 BGP: peer_ttl_security_hops_set: set gtsm_hops to 1 for uplink

Documentation: http://docs.frrouting.org/en/latest/bgp.html#clicmd-[no]neighborPEERttl-securityhopsNUMBER

This issue was reported upstream and fixed in master branch:
- https://github.com/FRRouting/frr/issues/7848
- https://github.com/donaldsharp/frr/commit/8a66632391db5f5181a4afef6aae41f48bee7fdb


Version-Release number of selected component (if applicable):
- OS Version: RHEL 8.3
- Kernel: Linux 4.18.0-240.el8.x86_64
- FRR Version: 7.5


Steps to Reproduce:
1. Set ttl-security hops in frr.conf. Example:

	hostname ctrl-3-0
	log file /var/log/frr/frr.log debugging
	service integrated-vtysh-config
	line vty

	router bgp 64999
	  bgp log-neighbor-changes
	  bgp graceful-shutdown

	  neighbor uplink peer-group
	  neighbor uplink remote-as internal
	  neighbor uplink bfd
	  neighbor uplink ttl-security hops 1
	  neighbor enp2s0 interface peer-group uplink
	  neighbor enp3s0 interface peer-group uplink

	  address-family ipv4 unicast
	    redistribute connected
	    neighbor uplink allowas-in origin
	  exit-address-family

	  address-family ipv6 unicast
	    redistribute connected
	    neighbor uplink activate
	    neighbor uplink allowas-in origin
	  exit-address-family

2. Start FRR with the BGP daemon enabled.
3. Check running configuration in vtysh

Actual results:

	[root@ctrl-3-0 frr]# vtysh -c 'show running-config'
	Building configuration...

	Current configuration:
	!
	frr version 7.5
	frr defaults traditional
	hostname ctrl-3-0
	log file /var/log/frr/frr.log
	no ipv6 forwarding
	!
	router bgp 64999
	 bgp log-neighbor-changes
	 bgp graceful-shutdown
	 neighbor uplink peer-group
	 neighbor uplink remote-as internal
	 neighbor uplink bfd
	 neighbor enp2s0 interface peer-group uplink
	 neighbor enp3s0 interface peer-group uplink
	 !
	 address-family ipv4 unicast
	  redistribute connected
	  neighbor uplink allowas-in origin
	 exit-address-family
	 !
	 address-family ipv6 unicast
	  redistribute connected
	  neighbor uplink activate
	  neighbor uplink allowas-in origin
	 exit-address-family
	!
	line vty
	!
	end


Expected results:
I would have expected to see an output line with neighbor uplink ttl-security hops 1.

Comment 1 Michal Ruprich 2021-01-27 14:40:50 UTC
Hi Carlos,

thanks for the report. The command gets applied but does not show in the running-config - I am setting the priority to low here because the command at least takes effect. Feel free to discuss the priority on this or add any customer case if there is one.

Regards,
Michal

Comment 2 Carlos Goncalves 2021-06-08 09:03:21 UTC
Any updates? This seems to be a straightforward cherry-pick from an upstream patch committed in master branch in mid-January and available in version 7.5.1 (released on March 8).

Comment 3 Michal Ruprich 2021-06-10 08:51:33 UTC
Created attachment 1789780 [details]
Patch

Comment 4 Michal Ruprich 2021-06-10 08:52:55 UTC
Hi Carlos,

yes, the cherry-pick of the patch is simple enough, frr just was not on a list to get updated in 8.5.0. I will propose this for next release since there are more bugs for FRR now.

Comment 18 errata-xmlrpc 2022-05-10 13:36:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (frr bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1778


Note You need to log in before you can comment on or make changes to this bug.