Bug 1917367 - Refactor periodic.go
Summary: Refactor periodic.go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Insights Operator
Version: 4.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.7.0
Assignee: Marcell Sevcsik
QA Contact: Pavel Šimovec
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-18 10:58 UTC by Marcell Sevcsik
Modified: 2021-02-24 15:54 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Feature: Refactors periodic.go Reason: periodic.go was written 2 years ago with a totally different idea on how the codebase should be structured compared to how it is structured now. This causes confusion in devs who dare to look at periodic.go, and also limits performance. Result: periodic.go is refactored in a way to mach the current structure of the codebase, it also increases performance/efficiency significantly.
Clone Of:
Environment:
Last Closed: 2021-02-24 15:53:53 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift insights-operator pull 302 0 None closed Bug 1917367: Refactor periodic.go 2021-01-28 13:19:02 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:54:11 UTC

Description Marcell Sevcsik 2021-01-18 10:58:48 UTC
Description of problem:

Refactors periodic.go in a way that it doesn't use overly complicated workload management (it should be the responsibility of the gatherers to manage the workloads) and as it was written ~2 years ago and wasn't changed since so it doesn't fit how the actual codebase developed since then. (we only have 1 Gatherer but that has multiple independent gather functions, yet periodic.go tries to manage multiple Gatherers)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Pavel Šimovec 2021-01-28 13:26:40 UTC
rebase of how the basis of collection works -> automated tests passed

Comment 5 errata-xmlrpc 2021-02-24 15:53:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.