Bug 1917495 - Review Request: perl-Date-Manip - Date manipulation routines
Summary: Review Request: perl-Date-Manip - Date manipulation routines
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora Modules
Classification: Fedora
Component: Module Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-18 15:21 UTC by Petr Pisar
Modified: 2021-06-15 07:41 UTC (History)
1 user (show)

Fixed In Version: perl-Date-Manip-6.83-3420210120162421.a450835c perl-Date-Manip-6.83-3420210120162421.7f057cb7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-15 07:41:25 UTC
Type: Bug
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2021-01-18 15:21:19 UTC
Modulemd URL: https://ppisar.fedorapeople.org/modulemds/perl-Date-Manip.yaml
Description:

Date::Manip is a series of modules designed to make any common
date/time operation easy to do. Operations such as comparing two
times, determining a data a given amount of time from another, or
parsing international times are all easily done. It deals with time as
it is used in the Gregorian calendar (the one currently in use) with
full support for time changes due to daylight saving time.

Fedora Account System Username: ppisar

An explanation for the modular dependencies: This module is intentionally only kept for platform:f34, because it's a multicontext stream (i.e. for multiple perls, like perl:5.30 and perl:5.32) and DNF does not properly support adding and removing contexts now (e.g. when adding perl:5.34 later). DNF team promised a fix in Fedora 34.

Comment 1 Jitka Plesnikova 2021-01-19 17:50:51 UTC
The module does not provide packages already existing in different module. Ok.
Summary is Ok.
License is Ok.
Build and run-time dependencies are Ok.
The profiles, api are Ok.
The component list is Ok.

User has commit rights for all components.

I was able to build the module successfully.
I verified the components have satisfied build-time dependencies.

This module is in line with Module packaging guidelines.

Resolution:
Module APPROVED

Comment 3 Gwyn Ciesla 2021-01-19 19:02:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/modules/perl-Date-Manip

Comment 5 Petr Pisar 2021-01-20 17:09:15 UTC
Thank you for the review and the repository.

Now waiting on resolving a rpmbuild crash on s390x <https://pagure.io/fedora-infrastructure/issue/9589>.

I will close this bug after defining a default profile in the repository.

Comment 7 Petr Pisar 2021-06-15 07:41:25 UTC
The default profiles are now in the repositories.


Note You need to log in before you can comment on or make changes to this bug.