Bug 1917512 - Review Request: perl-XML-Parser - Perl module for parsing XML documents
Summary: Review Request: perl-XML-Parser - Perl module for parsing XML documents
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora Modules
Classification: Fedora
Component: Module Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-18 15:56 UTC by Petr Pisar
Modified: 2021-06-15 07:38 UTC (History)
1 user (show)

Fixed In Version: perl-XML-Parser-2.46-3420210120110152.48f9df1a perl-XML-Parser-2.46-3420210120110152.5e94452c
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-15 07:38:59 UTC
Type: Bug
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2021-01-18 15:56:50 UTC
Modulemd URL: https://ppisar.fedorapeople.org/modulemds/perl-XML-Parser.yaml
Description:

This module provides ways to parse XML documents. It is built on top
of XML::Parser::Expat, which is a lower level interface to James
Clark's expat library. Each call to one of the parsing methods creates
a new instance of XML::Parser::Expat which is then used to parse the
document. Expat options may be provided when the XML::Parser object is
created. These options are then passed on to the Expat object on each
parse call. They can also be given as extra arguments to the parse
methods, in which case they override options given at XML::Parser
creation time.

Fedora Account System Username: ppisar

An explanation for the modular dependencies: This module is intentionally only kept for platform:f34, because it's a multicontext stream (i.e. for multiple perls, like perl:5.30 and perl:5.32) and DNF does not properly support adding and removing contexts now (e.g. when adding perl:5.34 later). DNF team promised a fix in Fedora 34.

Comment 1 Jitka Plesnikova 2021-01-19 16:32:06 UTC
The module does not provide packages already existing in different module. Ok.
Summary is Ok.
License is Ok.
Build and run-time dependencies are Ok.
The profiles, api, filter are Ok.
The component list is Ok.

User has commit rights for all components.

I was able to build the module successfully.
I verified the components have satisfied build-time dependencies.

This module is in line with Module packaging guidelines.

Resolution:
Module APPROVED

Comment 4 Petr Pisar 2021-01-20 11:07:37 UTC
Thank you for the review and the repository.

I added a missing modular dependency on perl-libwww-perl. Now waiting on resolving a rpmbuild crash on s390x <https://pagure.io/fedora-infrastructure/issue/9589>.

I will close this bug after defining a default profile in the repository.

Comment 6 Petr Pisar 2021-06-15 07:38:59 UTC
Default profiles are now in the repositories.


Note You need to log in before you can comment on or make changes to this bug.