Bug 191782 - Review Request: rafkill - Top-down shooter with powerups
Summary: Review Request: rafkill - Top-down shooter with powerups
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-15 19:12 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-18 07:12:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Hans de Goede 2006-05-15 19:12:44 UTC
Spec URL: http://people.atrpms.net/~hdegoede/rafkill.spec
SRPM URL: http://people.atrpms.net/~hdegoede/rafkill-1.2.1-1.src.rpm
Description:

Rafkill is a vertical scrolling shoot-em up game. You can collect powerups
during gameplay and you can goto the store with your spaceship and buy
powerups or even a complete new ship with the points you've earned sofar.

Comment 1 John Mahowald 2006-05-18 05:21:26 UTC
- rpmlint checks return clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file 
- works!

APPROVED

Comment 2 Hans de Goede 2006-05-18 07:12:34 UTC
Thanks for the review!

Imported and build.


Note You need to log in before you can comment on or make changes to this bug.