Bug 1917848 - [RFE] Add hardware panel to Hosts Inventory Dashboard
Summary: [RFE] Add hardware panel to Hosts Inventory Dashboard
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Grafana
Version: 4.4.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.4.5
: 4.4.5.4
Assignee: Aviv Litman
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-19 14:27 UTC by Aviv Litman
Modified: 2021-03-18 15:13 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-dwh-4.4.5.4
Doc Type: Release Note
Doc Text:
If this bug requires documentation, please select an appropriate Doc Type value.
Clone Of:
Environment:
Last Closed: 2021-03-18 15:13:18 UTC
oVirt Team: Metrics
Embargoed:
mperina: ovirt-4.4?
pm-rhel: planning_ack?
mperina: devel_ack+
gdeolive: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 113249 0 master MERGED Add hardware panel to Hosts Inventory Dashboard 2021-02-19 20:04:33 UTC

Description Aviv Litman 2021-01-19 14:27:02 UTC
we want to add new panel to Hosts Inventory Dashboard with data about the host hardware.
In order to see for each host the:
-hardware_manufacturer (Server Manufacturer)
-hardware_product_name (Server Name)
-hardware_serial_number (Server Serial Number)
-host_type (Host / Hypervisor)

Comment 1 Pavel Novotny 2021-03-01 21:51:59 UTC
Functionally-wise it's verified (ovirt-engine-4.4.5.7-0.1.el8ev.noarch ovirt-engine-dwh-4.4.5.4-1.el8ev.noarch).
The Hosts HW Details table shows all the data (Host Name, CPU Model, Number of CPUs, Memory Size, Server Manufacturer, Server Name, Server Serial Number).

But I found a possible regression regarding to bug 1914825 where all the views should be updated from v4_3 to v4_4.
The panel current query is using view v4_3_configuration_history_hosts:


SELECT DISTINCT 
    CASE 
        WHEN delete_date IS NULL  	     	    
            THEN host_name 	 	
        WHEN delete_date IS NOT NULL  	      	    
            THEN host_name || ' (Removed on ' || CAST ( CAST ( delete_date AS date ) AS varchar ) || ')'
    END AS host_name,
    cpu_model,
    number_of_cores AS host_cpu,
    ROUND ( CAST ( COALESCE ( memory_size_mb, 0.00 ) AS float ) :: numeric / 1024, 1 ) AS host_memsize,
    hardware_manufacturer AS "Server Manufacturer",
    hardware_product_name AS "Server Name",
    hardware_serial_number AS "Server Serial Number"
FROM v4_4_configuration_history_hosts
WHERE 
    host_id IN ($host_id)
    AND
        history_id
            IN
                (
                    SELECT MAX (history_id)
                    FROM v4_3_configuration_history_hosts
                    GROUP BY host_id
                )
    AND
        CASE
            WHEN '$show_deleted'='Yes'
                THEN 1=1
            WHEN '$show_deleted'='No'
                THEN delete_date isnull
        END
ORDER BY host_name, hardware_manufacturer, hardware_product_name


@Aviv: if the v4_3 view is intentional, then this RFE is verified.
If not, I don't mind to verify this bug anyway and the view name can be fixed in a separate bug.

Comment 2 Aviv Litman 2021-03-03 07:49:52 UTC
Hi Pavel Thanks for notice that. the v4_3 view is not intentional.
you can verify this bug and the view name will be fixed in a separate bug.

Thanks

Comment 3 Aviv Litman 2021-03-03 08:05:44 UTC
The view name fixed in this patch: https://gerrit.ovirt.org/#/c/ovirt-dwh/+/113755/

Comment 4 Pavel Novotny 2021-03-03 14:13:02 UTC
All right, then moving to VERIFIED.

Comment 5 Sandro Bonazzola 2021-03-18 15:13:18 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.