Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 4 product line. The current stable release is 4.9. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 191793

Summary: [PATCH] i386: Move phys_proc_id/early intel workaround to correct function
Product: Red Hat Enterprise Linux 4 Reporter: Jason Baron <jbaron>
Component: kernelAssignee: John Villalovos <jvillalo>
Status: CLOSED NOTABUG QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: jbaron, jvillalo, knoel
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-24 19:45:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
intel_early_workaround() moved to generic_identify() as early_detect_cpus() only run at BP. none

Description Jason Baron 2006-05-15 20:33:24 UTC 
Description of problem:

please see:


http://kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.15.y.git;a=commitdiff;h=bcf2887b1416a506e3461c504642a1b7fad52ddc
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Bhavna Sarathy 2006-05-15 20:50:39 UTC 
Created attachment 129118 [details]
intel_early_workaround() moved to generic_identify() as early_detect_cpus() only run at BP.

Geoff, please test this patch, please.	 I can submit it to rhkernel-list soon
after.
Comment 2 Geoff Gustafson 2006-05-17 20:16:52 UTC 
I sanity-checked on one box. Oddly generic_identify gets run twice on each proc,
but same upstream. Looks fine.
Comment 3 Geoff Gustafson 2008-02-05 19:46:40 UTC 
We've made it this far without anyone tearing their hair out, I'm tempted to
think this couldn't possibly matter. But I'll check with the mothership before
giving up on it.
Comment 4 Geoff Gustafson 2008-02-06 17:19:03 UTC 
Suresh pointed out, and I confirmed in the latest EL4 source, that the
x86_cache_alignment field this function sets is only ever read with the macro
cache_line_size() which reads it from the boot cpu. So the patch isn't really
needed.

The one exception to this is reporting to /proc/cpuinfo, so on some machine I
guess it will show 128 for boot cpu and incorrectly show 64 for others. But I'm
not sure that makes it worth posting.
Comment 5 John Villalovos 2009-04-24 19:45:27 UTC 
From Comment 4, it doesn't seem like this is a bug.  Or at least not worth posting a patch.

Please re-open if disagree.