Bug 1918150

Hi Ben, 
This is a IBM power10 server. Do you have IBM VPN account? Can you login IBM Yellow Zone?
If yes, you can login rhyzden1-lp6.yz.ibm using root/beaker to check it.
Thanks!

I wouldn't call this a bug.  From multipath's point of view, your config file looks like:

blacklist_exceptions {
	property "(SCSI_IDENT_|ID_WWN)"
}
devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
        overrides {  <-------------- ignored garbage line
}
multipaths {
	multipath {
		wwid "333333330000007d1"
		# alias "mpatha"
                path_grouping_policy "multibus"
	}
}

Since you removed the closing parenthesis to the devices section, when multipath sees the overrides line, it is still processing the devices section.  The devices section doesn't have any keyword named overrides, so multipath just prints an warning and ignores it. It doesn't start a new subsection because the devices section doesn't have an overrides subsection to start.  When it sees the closing parenthesis to the overrides section, it treats it as the closing parenthesis of the devices section because that is the section it is still in.

Multipath's configuration parsing is not designed with a list of keywords and information about what sections they belong in. Each section only knows about the keywords that are valid in it, and what to do when they exist. There is no way with the current design for multipath to know that "overrides" is a valid keyword, it just doesn't belong to the devices section. Changing that would be a lot of work for not much benefit. Multipath still warns the user that there is an error, and flags the line where the error is. I could probably change the error message to say something like

"invalid keyword in the devices section: overrides"

so that users get a hint that multipath still is processing the devices section. How does that sound?

it is fine that "invalid keyword in the devices section: overrides".
Thanks Ben.

Verified on device-mapper-multipath-0.8.4-19.el8
1.[root@ibm-p9z-20-lp13 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.4-19.el8.ppc64le
device-mapper-multipath-0.8.4-19.el8.ppc64le

2.[root@ibm-p9z-20-lp13 ~]# cat /etc/multipath.conf 
defaults {
	verbosity 2
	polling_interval 5
	max_polling_interval 20
	reassign_maps "no"
	multipath_dir "/lib64/multipath"
	path_selector "service-time 0"
	path_grouping_policy "failover"
	uid_attribute "ID_SERIAL"
	prio "const"
	prio_args ""
	features "0"
	path_checker "tur"
	alias_prefix "mpath"
	failback "manual"
	rr_min_io 1000
	rr_min_io_rq 1
	max_fds "max"
	rr_weight "uniform"
	queue_without_daemon "no"
	flush_on_last_del "no"
	user_friendly_names "yes"
	fast_io_fail_tmo 5
	bindings_file "/etc/multipath/bindings"
	wwids_file "/etc/multipath/wwids"
	prkeys_file "/etc/multipath/prkeys"
	log_checker_err always
	all_tg_pt "no"
	retain_attached_hw_handler "yes"
	detect_prio "yes"
	detect_checker "yes"
	force_sync "no"
	strict_timing "no"
	deferred_remove "no"
	config_dir "/etc/multipath/conf.d"
	delay_watch_checks "no"
	delay_wait_checks "no"
	san_path_err_threshold "no"
	san_path_err_forget_rate "no"
	san_path_err_recovery_time "no"
	marginal_path_err_sample_time "no"
	marginal_path_err_rate_threshold "no"
	marginal_path_err_recheck_gap_time "no"
	marginal_path_double_failed_time "no"
	find_multipaths "on"
	uxsock_timeout 4000
	retrigger_tries 3
	retrigger_delay 10
	missing_uev_wait_timeout 30
	skip_kpartx "no"
	disable_changed_wwids ignored
	remove_retries 0
	ghost_delay "no"
	find_multipaths_timeout -10
	enable_foreign "^$"
	marginal_pathgroups "no"
}
blacklist {
	devnode "!^(sd[a-z]|dasd[a-z]|nvme[0-9])"
	device {
		vendor "SGI"
		product "Universal Xport"
	}
	device {
		vendor "^DGC"
		product "LUNZ"
	}
	device {
		vendor "EMC"
		product "LUNZ"
	}
	device {
		vendor "DELL"
		product "Universal Xport"
	}
	device {
		vendor "FUJITSU"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "S/390"
	}
	device {
		vendor "LENOVO"
		product "Universal Xport"
	}
	device {
		vendor "(NETAPP|LSI|ENGENIO)"
		product "Universal Xport"
	}
	device {
		vendor "STK"
		product "Universal Xport"
	}
	device {
		vendor "SUN"
		product "Universal Xport"
	}
	device {
		vendor "(Intel|INTEL)"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "Vess V-LUN"
	}
}
blacklist_exceptions {
	property "(SCSI_IDENT_|ID_WWN)"
}
devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
#}  <-------------------------------------------------------------
overrides {
}
multipaths {
	multipath {
		wwid "333333330000007d1"
		# alias "mpatha"
                path_grouping_policy "multibus"
	}
}

3.[root@ibm-p9z-20-lp13 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4.[root@ibm-p9z-20-lp13 ~]# multipath -ll
Nov 15 09:13:49 | /etc/multipath.conf line 128, invalid keyword in the devices section: overrides    <-----------------------------------------
mpatha (3600601605e203f00d6ed8ff61e07eb11) dm-0 DGC,VRAID
size=8.0G features='1 queue_if_no_path' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:1:0 sdb 8:16 active ready running
| `- 2:0:1:0 sdd 8:48 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:0:0 sda 8:0  active ready running
  `- 2:0:0:0 sdc 8:32 active ready running



Test result: multipath reports "invalid keyword in the devices section: overrides"

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (device-mapper-multipath bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2036