RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1918150 - [IBM power10] multipathd reported incorrect error when /etc/multipath.conf lack of }
Summary: [IBM power10] multipathd reported incorrect error when /etc/multipath.conf la...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: device-mapper-multipath
Version: 8.4
Hardware: ppc64le
OS: Linux
low
high
Target Milestone: rc
: 8.0
Assignee: Ben Marzinski
QA Contact: Lin Li
URL:
Whiteboard:
Depends On:
Blocks: 1903942
TreeView+ depends on / blocked
 
Reported: 2021-01-20 08:06 UTC by Lin Li
Modified: 2022-05-10 16:36 UTC (History)
6 users (show)

Fixed In Version: device-mapper-multipath-0.8.4-19.el8
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-10 15:21:50 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2022:2036 0 None None None 2022-05-10 15:22:19 UTC

Description Lin Li 2021-01-20 08:06:56 UTC
Description of problem:
[IBM power10] multipathd reported incorrect error when /etc/multipath.conf lack of }

Version-Release number of selected component (if applicable):
device-mapper-multipath-0.8.4-7.el8.ppc64le

How reproducible:
always

Steps to Reproduce:
1.[root@rhyzden1-lp6 ~]# rpm -qa | grep multipath
device-mapper-multipath-0.8.4-7.el8.ppc64le
device-mapper-multipath-libs-0.8.4-7.el8.ppc64le
2.Edit /etc/multipath.conf
[root@rhyzden1-lp6 ~]# cat /etc/multipath.conf
defaults {
	verbosity 2
	polling_interval 5
	max_polling_interval 20
	reassign_maps "no"
	multipath_dir "/lib64/multipath"
	path_selector "service-time 0"
	path_grouping_policy "failover"
	uid_attribute "ID_SERIAL"
	prio "const"
	prio_args ""
	features "0"
	path_checker "tur"
	alias_prefix "mpath"
	failback "manual"
	rr_min_io 1000
	rr_min_io_rq 1
	max_fds "max"
	rr_weight "uniform"
	queue_without_daemon "no"
	flush_on_last_del "no"
	user_friendly_names "yes"
	fast_io_fail_tmo 5
	bindings_file "/etc/multipath/bindings"
	wwids_file "/etc/multipath/wwids"
	prkeys_file "/etc/multipath/prkeys"
	log_checker_err always
	all_tg_pt "no"
	retain_attached_hw_handler "yes"
	detect_prio "yes"
	detect_checker "yes"
	force_sync "no"
	strict_timing "no"
	deferred_remove "no"
	config_dir "/etc/multipath/conf.d"
	delay_watch_checks "no"
	delay_wait_checks "no"
	san_path_err_threshold "no"
	san_path_err_forget_rate "no"
	san_path_err_recovery_time "no"
	marginal_path_err_sample_time "no"
	marginal_path_err_rate_threshold "no"
	marginal_path_err_recheck_gap_time "no"
	marginal_path_double_failed_time "no"
	find_multipaths "on"
	uxsock_timeout 4000
	retrigger_tries 3
	retrigger_delay 10
	missing_uev_wait_timeout 30
	skip_kpartx "no"
	disable_changed_wwids ignored
	remove_retries 0
	ghost_delay "no"
	find_multipaths_timeout -10
	enable_foreign "^$"
	marginal_pathgroups "no"
}
blacklist {
	devnode "!^(sd[a-z]|dasd[a-z]|nvme[0-9])"
	device {
		vendor "SGI"
		product "Universal Xport"
	}
	device {
		vendor "^DGC"
		product "LUNZ"
	}
	device {
		vendor "EMC"
		product "LUNZ"
	}
	device {
		vendor "DELL"
		product "Universal Xport"
	}
	device {
		vendor "FUJITSU"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "S/390"
	}
	device {
		vendor "LENOVO"
		product "Universal Xport"
	}
	device {
		vendor "(NETAPP|LSI|ENGENIO)"
		product "Universal Xport"
	}
	device {
		vendor "STK"
		product "Universal Xport"
	}
	device {
		vendor "SUN"
		product "Universal Xport"
	}
	device {
		vendor "(Intel|INTEL)"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "Vess V-LUN"
	}
}
blacklist_exceptions {
	property "(SCSI_IDENT_|ID_WWN)"
}
devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
#}  <-------------------------------------------------------------
overrides {
}
multipaths {
	multipath {
		wwid "333333330000007d1"
		# alias "mpatha"
                path_grouping_policy "multibus"
	}
}
 

3.[root@rhyzden1-lp6 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4.[root@rhyzden1-lp6 ~]# multipath -ll
Jan 20 01:41:23 | /etc/multipath.conf line 128, invalid keyword: overrides
mpatha (333333330000007d1) dm-3 Linux,scsi_debug
size=1.0G features='0' hwhandler='1 alua' wp=rw
`-+- policy='service-time 0' prio=17 status=active
  |- 1:0:0:1 sdb 8:16 active ready running
  |- 2:0:0:1 sdc 8:32 failed ready running
  |- 3:0:0:1 sdd 8:48 active ready running
  `- 4:0:0:1 sde 8:64 active ready running

Actual results:
multipath reported "invalid keyword: overrides" not "missing '}' "

Expected results:
multipath should report "missing '}'" 

Additional info:

Comment 1 Lin Li 2021-01-20 08:10:06 UTC
Hi Ben, 
This is a IBM power10 server. Do you have IBM VPN account? Can you login IBM Yellow Zone?
If yes, you can login rhyzden1-lp6.yz.ibm using root/beaker to check it.
Thanks!

Comment 2 Ben Marzinski 2021-01-21 00:46:38 UTC
I wouldn't call this a bug.  From multipath's point of view, your config file looks like:

blacklist_exceptions {
	property "(SCSI_IDENT_|ID_WWN)"
}
devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
        overrides {  <-------------- ignored garbage line
}
multipaths {
	multipath {
		wwid "333333330000007d1"
		# alias "mpatha"
                path_grouping_policy "multibus"
	}
}

Since you removed the closing parenthesis to the devices section, when multipath sees the overrides line, it is still processing the devices section.  The devices section doesn't have any keyword named overrides, so multipath just prints an warning and ignores it. It doesn't start a new subsection because the devices section doesn't have an overrides subsection to start.  When it sees the closing parenthesis to the overrides section, it treats it as the closing parenthesis of the devices section because that is the section it is still in.

Multipath's configuration parsing is not designed with a list of keywords and information about what sections they belong in. Each section only knows about the keywords that are valid in it, and what to do when they exist. There is no way with the current design for multipath to know that "overrides" is a valid keyword, it just doesn't belong to the devices section. Changing that would be a lot of work for not much benefit. Multipath still warns the user that there is an error, and flags the line where the error is. I could probably change the error message to say something like

"invalid keyword in the devices section: overrides"

so that users get a hint that multipath still is processing the devices section. How does that sound?

Comment 3 Lin Li 2021-01-21 02:43:20 UTC
it is fine that "invalid keyword in the devices section: overrides".
Thanks Ben.

Comment 9 Lin Li 2021-11-15 14:19:39 UTC
Verified on device-mapper-multipath-0.8.4-19.el8
1.[root@ibm-p9z-20-lp13 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.4-19.el8.ppc64le
device-mapper-multipath-0.8.4-19.el8.ppc64le

2.[root@ibm-p9z-20-lp13 ~]# cat /etc/multipath.conf 
defaults {
	verbosity 2
	polling_interval 5
	max_polling_interval 20
	reassign_maps "no"
	multipath_dir "/lib64/multipath"
	path_selector "service-time 0"
	path_grouping_policy "failover"
	uid_attribute "ID_SERIAL"
	prio "const"
	prio_args ""
	features "0"
	path_checker "tur"
	alias_prefix "mpath"
	failback "manual"
	rr_min_io 1000
	rr_min_io_rq 1
	max_fds "max"
	rr_weight "uniform"
	queue_without_daemon "no"
	flush_on_last_del "no"
	user_friendly_names "yes"
	fast_io_fail_tmo 5
	bindings_file "/etc/multipath/bindings"
	wwids_file "/etc/multipath/wwids"
	prkeys_file "/etc/multipath/prkeys"
	log_checker_err always
	all_tg_pt "no"
	retain_attached_hw_handler "yes"
	detect_prio "yes"
	detect_checker "yes"
	force_sync "no"
	strict_timing "no"
	deferred_remove "no"
	config_dir "/etc/multipath/conf.d"
	delay_watch_checks "no"
	delay_wait_checks "no"
	san_path_err_threshold "no"
	san_path_err_forget_rate "no"
	san_path_err_recovery_time "no"
	marginal_path_err_sample_time "no"
	marginal_path_err_rate_threshold "no"
	marginal_path_err_recheck_gap_time "no"
	marginal_path_double_failed_time "no"
	find_multipaths "on"
	uxsock_timeout 4000
	retrigger_tries 3
	retrigger_delay 10
	missing_uev_wait_timeout 30
	skip_kpartx "no"
	disable_changed_wwids ignored
	remove_retries 0
	ghost_delay "no"
	find_multipaths_timeout -10
	enable_foreign "^$"
	marginal_pathgroups "no"
}
blacklist {
	devnode "!^(sd[a-z]|dasd[a-z]|nvme[0-9])"
	device {
		vendor "SGI"
		product "Universal Xport"
	}
	device {
		vendor "^DGC"
		product "LUNZ"
	}
	device {
		vendor "EMC"
		product "LUNZ"
	}
	device {
		vendor "DELL"
		product "Universal Xport"
	}
	device {
		vendor "FUJITSU"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "Universal Xport"
	}
	device {
		vendor "IBM"
		product "S/390"
	}
	device {
		vendor "LENOVO"
		product "Universal Xport"
	}
	device {
		vendor "(NETAPP|LSI|ENGENIO)"
		product "Universal Xport"
	}
	device {
		vendor "STK"
		product "Universal Xport"
	}
	device {
		vendor "SUN"
		product "Universal Xport"
	}
	device {
		vendor "(Intel|INTEL)"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "VTrak V-LUN"
	}
	device {
		vendor "Promise"
		product "Vess V-LUN"
	}
}
blacklist_exceptions {
	property "(SCSI_IDENT_|ID_WWN)"
}
devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
#}  <-------------------------------------------------------------
overrides {
}
multipaths {
	multipath {
		wwid "333333330000007d1"
		# alias "mpatha"
                path_grouping_policy "multibus"
	}
}

3.[root@ibm-p9z-20-lp13 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4.[root@ibm-p9z-20-lp13 ~]# multipath -ll
Nov 15 09:13:49 | /etc/multipath.conf line 128, invalid keyword in the devices section: overrides    <-----------------------------------------
mpatha (3600601605e203f00d6ed8ff61e07eb11) dm-0 DGC,VRAID
size=8.0G features='1 queue_if_no_path' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:1:0 sdb 8:16 active ready running
| `- 2:0:1:0 sdd 8:48 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:0:0 sda 8:0  active ready running
  `- 2:0:0:0 sdc 8:32 active ready running



Test result: multipath reports "invalid keyword in the devices section: overrides"

Comment 11 errata-xmlrpc 2022-05-10 15:21:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (device-mapper-multipath bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2036


Note You need to log in before you can comment on or make changes to this bug.