Bug 1918275 - Review Request: libusb-compat-0.1 - Compatibility shim around libusb-1.0 offering the old 0.1 API
Summary: Review Request: libusb-compat-0.1 - Compatibility shim around libusb-1.0 offe...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
Depends On: 1918269
TreeView+ depends on / blocked
Reported: 2021-01-20 11:30 UTC by Benjamin Berg
Modified: 2022-03-07 14:23 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-03-07 14:23:36 UTC
Type: Bug
hdegoede: fedora-review+

Attachments (Terms of Use)

Comment 1 Hans de Goede 2021-02-03 13:32:58 UTC
I'm doing a full review of this now, taking this and moving it to assigned.

Also fixing up the Component and Summary to match the template, to make sure non of the automated tooling trips over this.

Comment 2 Hans de Goede 2021-02-03 15:14:22 UTC
Full review done, with the help of fedora-review; and with the parts which fedora-review does not do automatically filled in manually.

I have found 2 small issues:

1. The F34 rebuild has build a libusb-0.1.7-3.fc34, so you need to bump the release field for the Obsoletes to work.

2. When expecting the Requires of the new package (which the fedora-review tool lists, see below) I noticed that it no longer has a (generated) Requires on: 'libusb-1.0.so.0()(64bit)' . Digging a bit deeper this is related to libusb-compat supporting ldopen-ing libusb1 so that it does not polute the ld namespace with libusb1 symbols. This is not something new, but until now this was not being used on Fedora:

The build log for the F33 build in koji has this:
"checking for SONAME of libusb-1.0... sed: -e expression #1, char 40: Invalid back reference unknown"
which is causing the configure script / code to fallback to direct linking.

Where as the build log for the F34 build in koji has this:
"checking for SONAME of libusb-1.0... libusb-1.0.so.0"

And ldopen is used (I assume) and the (generated) Requires on: 'libusb-1.0.so.0()(64bit)' is gone. This means that an explicit:

Requires: libusb1

Needs to be added to the spec-file for the main package.

I trust that you will fix these before importing this, so this packages is Approved.

See below for all the review-checks done:

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license (LGPLv2+)
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see below).
[x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures.
[-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on debuginfo package(s).
[x]: Rpmlint is run on all installed packages.
[-]: Large data in /usr/share should live in a noarch subpackage if package is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: libusb-compat-0.1-0.1.7-3.fc34.x86_64.rpm
libusb-compat-0.1.x86_64: W: shared-lib-calls-exit /usr/lib64/libusb-0.1.so.4.4.4 exit.5
libusb-compat-0.1-devel.x86_64: W: obsolete-not-provided libusb-devel
libusb-compat-0.1-devel.x86_64: W: no-documentation
libusb-compat-0.1-devel.x86_64: W: no-manual-page-for-binary libusb-config
libusb-compat-0.1-tests-examples.x86_64: W: no-documentation
libusb-compat-0.1-tests-examples.x86_64: W: no-manual-page-for-binary libusb-compat-0.1-lsusb
libusb-compat-0.1-tests-examples.x86_64: W: no-manual-page-for-binary libusb-compat-0.1-testlibusb
libusb-compat-0.1.src:12: W: unversioned-explicit-provides deprecated()
6 packages and 0 specfiles checked; 0 errors, 8 warnings.

libusb-compat-0.1 (rpmlib, GLIBC filtered):

libusb-compat-0.1-devel (rpmlib, GLIBC filtered):

libusb-compat-0.1-tests-examples (rpmlib, GLIBC filtered):

libusb-compat-0.1-debuginfo (rpmlib, GLIBC filtered):

libusb-compat-0.1-debugsource (rpmlib, GLIBC filtered):

Comment 3 Hans de Goede 2021-02-03 15:19:11 UTC
I just realized that the:

Requires: libusb1

Should be:

Requires: libusb1%{?_isa}

Comment 4 Mohan Boddu 2021-02-10 15:49:06 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libusb-compat-0.1

Comment 5 Mattia Verga 2022-02-21 09:52:05 UTC
This package was never imported, Benjamin are you still on it?

Comment 6 Benjamin Berg 2022-02-21 10:54:21 UTC
Huh, I completely forgot about this. AFAIK, the package has been ready for a long time. It just needs pushing out and then killing off the libusb package.

But, a bit late for the F36 cycle (in particular because I really need to do more stuff around libusb1 ATM). In particular as pushing it will trigger FTBFS situations where packagers need to decide whether to depend on libusb1 or libusb-compat-0.1.

So, I would say, the best thing is to import this into rawhide after F36 beta has frozen.

Comment 7 Hans de Goede 2022-02-21 12:18:14 UTC
(In reply to Benjamin Berg from comment #6)
> Huh, I completely forgot about this. AFAIK, the package has been ready for a
> long time. It just needs pushing out and then killing off the libusb package.
> But, a bit late for the F36 cycle (in particular because I really need to do
> more stuff around libusb1 ATM). In particular as pushing it will trigger
> FTBFS situations where packagers need to decide whether to depend on libusb1
> or libusb-compat-0.1.
> So, I would say, the best thing is to import this into rawhide after F36
> beta has frozen.

I agree this is probably rawhide only material, but once you've fixed the libusb1-1.0.25-4 breakage, then you can start working on this right away, since F36 has already branched of from rawhide.

Comment 8 Benjamin Berg 2022-03-07 14:23:36 UTC
Pushed to rawhide. Also, libusb is now retired in rawhide.


Note You need to log in before you can comment on or make changes to this bug.