Description of problem: This is a request for a new rpm for the collectd-config-ansible-role [1], which is required for deploying collectd in tripleo with ansible. Currently the addition of this service in tripleo-heat-templates is WIP [2] The change in THT will depend on the tripleo-collectd-ansible-role [3] which will eventually become part of tripleo_ansible, and depends on [1]. [1] is what requires packaging. A spec file is located at [4] [1] https://github.com/infrawatch/collectd-config-ansible-role [2] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/737100 [3] https://github.com/infrawatch/tripleo-collectd-ansible-role [4] https://github.com/infrawatch/collectd-config-ansible-role/blob/master/collectd-config-ansible-role.spec Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
licensecheck output: $ licensecheck -r . ./.ansible-lint: *No copyright* UNKNOWN ./.yamllint: *No copyright* UNKNOWN ./LICENSE: Apache License 2.0 GENERATED FILE ./README.md: *No copyright* UNKNOWN ./defaults/main.yml: *No copyright* UNKNOWN ./meta/main.yml: *No copyright* UNKNOWN ./tasks/configure_collectd.yml: *No copyright* UNKNOWN ./tasks/deploy_steps_tasks.yml: *No copyright* UNKNOWN ./tasks/fast_forward_upgrade_tasks.yml: *No copyright* UNKNOWN ./tasks/host_prep_tasks.yml: *No copyright* UNKNOWN ./tasks/main.yml: *No copyright* UNKNOWN ./vars/main.yml: *No copyright* GENERATED FILE ./.github/workflows/main.yml: *No copyright* UNKNOWN ./molecule/amqp_connection/INSTALL.rst: *No copyright* UNKNOWN ./molecule/amqp_connection/converge.yml: *No copyright* UNKNOWN ./molecule/amqp_connection/molecule.yml: *No copyright* UNKNOWN ./molecule/amqp_connection/verify.yml: *No copyright* UNKNOWN ./molecule/amqp_default_interval/INSTALL.rst: *No copyright* UNKNOWN ./molecule/amqp_default_interval/converge.yml: *No copyright* UNKNOWN ./molecule/amqp_default_interval/molecule.yml: *No copyright* UNKNOWN ./molecule/amqp_default_interval/verify.yml: *No copyright* UNKNOWN ./molecule/collectd_connection/INSTALL.rst: *No copyright* UNKNOWN ./molecule/collectd_connection/converge.yml: *No copyright* UNKNOWN ./molecule/collectd_connection/molecule.yml: *No copyright* UNKNOWN ./molecule/collectd_connection/verify.yml: *No copyright* UNKNOWN ./molecule/common/prepare.yml: *No copyright* UNKNOWN ./molecule/common/requirements.yml: *No copyright* UNKNOWN ./molecule/common/verify.yml: *No copyright* UNKNOWN ./molecule/default/INSTALL.rst: *No copyright* UNKNOWN ./molecule/default/converge.yml: *No copyright* UNKNOWN ./molecule/default/molecule.yml: *No copyright* UNKNOWN ./molecule/default/requirements.yml: *No copyright* UNKNOWN ./molecule/default/verify.yml: *No copyright* UNKNOWN ./tests/kolla_config_files/config.json: *No copyright* UNKNOWN License is valid ASL 2.0. Please go on with next step of new packages process in https://www.rdoproject.org/documentation/add-packages/
BTW, i think a better package name would be ansible-role-tripleo-collectd, it'd be more consistent with names in victoria (although we have not been very consistent with ansible roles naming): ansible-config_template-1.1.1-1.el8 ansible-freeipa-0.1.8-2.el8 ansible-pacemaker-1.0.4-0.1.5847167git.el8 ansible-role-atos-hsm-0.1.0-2.e51c244git.el8 ansible-role-chrony-1.0.1-1.el8 ansible-role-container-registry-1.2.0-1.el8 ansible-role-lunasa-hsm-1.0.0-1.el8 ansible-role-openstack-operations-0.0.1-0.1.09e0e81git.el8 ansible-role-redhat-subscription-1.1.0-1.el8 ansible-role-thales-hsm-0.2.0-2.99b3d39git.el8 ansible-role-tripleo-modify-image-1.2.0-1.el8 tripleo-ansible-2.1.0-1.el8 ansible-tripleo-ipa-0.2.0-1.el8 ansible-tripleo-ipsec-9.3.0-1.el8 Also, consider create some tag release when the repo is ready to be used, please.
I think there's some confusion, the license check above was done on tripleo-collectd-ansible-role, which will be part of tripleo_ansible. The package I am requesting is collectd-config-ansible-role [1], which is used by the tripleo-collectd-ansible-role. The separation between these is for two reasons: 1- puppet does it this way, and we are replacing puppet, and 2- the collectd_config role can be reused elsewhere, such as in STF. In terms of naming, I can update the package name (which varies from the repo, and the installed role name anyway) to ansible-role-collectd-config, rather than ansible-collectd-config, which matches the majority of the naming patterns above. [1] https://github.com/infrawatch/collectd-config-ansible-role.
Yes sorry for the confussion The good one: $ licensecheck -r . ./.ansible-lint: *No copyright* UNKNOWN ./.yamllint: *No copyright* UNKNOWN ./LICENSE: Apache License 2.0 GENERATED FILE ./README.rst: *No copyright* UNKNOWN ./collectd-config-ansible-role.spec: *No copyright* UNKNOWN ./build_tools/README.rst: *No copyright* UNKNOWN ./build_tools/build_rpms.sh: *No copyright* UNKNOWN ./handlers/main.yml: *No copyright* UNKNOWN ./meta/main.yml: *No copyright* UNKNOWN ./tasks/main.yml: *No copyright* UNKNOWN ./templates/amqp1.conf.j2: *No copyright* UNKNOWN ./templates/capabilities.conf.j2: *No copyright* UNKNOWN ./templates/ceph.conf.j2: *No copyright* UNKNOWN ./templates/collectd.conf.j2: *No copyright* UNKNOWN ./templates/connectivity.conf.j2: *No copyright* UNKNOWN ./templates/contextswitch.conf.j2: *No copyright* UNKNOWN ./templates/cpu.conf.j2: *No copyright* UNKNOWN ./templates/cpufreq.conf.j2: *No copyright* UNKNOWN ./templates/cpusleep.conf.j2: *No copyright* UNKNOWN ./templates/csv.conf.j2: *No copyright* UNKNOWN ./templates/dcpmm.conf.j2: *No copyright* UNKNOWN ./templates/df.conf.j2: *No copyright* UNKNOWN ./templates/disk.conf.j2: *No copyright* UNKNOWN ./templates/dns.conf.j2: *No copyright* UNKNOWN ./templates/ethstat.conf.j2: *No copyright* UNKNOWN ./templates/exec.conf.j2: *No copyright* UNKNOWN ./templates/hddtemp.conf.j2: *No copyright* UNKNOWN ./templates/hugepages.conf.j2: *No copyright* UNKNOWN ./templates/intel_pmu.conf.j2: *No copyright* UNKNOWN ./templates/intel_rdt.conf.j2: *No copyright* UNKNOWN ./templates/interface.conf.j2: *No copyright* UNKNOWN ./templates/ipc.conf.j2: *No copyright* UNKNOWN ./templates/ipmi.conf.j2: *No copyright* UNKNOWN ./templates/irq.conf.j2: *No copyright* UNKNOWN ./templates/libpodstats.conf.j2: *No copyright* UNKNOWN ./templates/load.conf.j2: *No copyright* UNKNOWN ./templates/logfile.conf.j2: *No copyright* UNKNOWN ./templates/mdevents.conf.j2: *No copyright* UNKNOWN ./templates/memory.conf.j2: *No copyright* UNKNOWN ./templates/netlink.conf.j2: *No copyright* UNKNOWN ./templates/network.conf.j2: *No copyright* UNKNOWN ./templates/ntpd.conf.j2: *No copyright* UNKNOWN ./templates/numa.conf.j2: *No copyright* UNKNOWN ./templates/ovs_stats.conf.j2: *No copyright* UNKNOWN ./templates/ping.conf.j2: *No copyright* UNKNOWN ./templates/processes.conf.j2: *No copyright* UNKNOWN ./templates/procevent.conf.j2: *No copyright* UNKNOWN ./templates/smart.conf.j2: *No copyright* UNKNOWN ./templates/swap.conf.j2: *No copyright* UNKNOWN ./templates/syslog.conf.j2: *No copyright* UNKNOWN ./templates/turbostat.conf.j2: *No copyright* UNKNOWN ./templates/unixsock.conf.j2: *No copyright* UNKNOWN ./templates/uptime.conf.j2: *No copyright* UNKNOWN ./templates/uuid.conf.j2: *No copyright* UNKNOWN ./templates/virt.conf.j2: *No copyright* UNKNOWN ./templates/vmem.conf.j2: *No copyright* UNKNOWN ./templates/write_http.conf.j2: *No copyright* UNKNOWN ./templates/write_prometheus.conf.j2: *No copyright* UNKNOWN ./tests/inventory: *No copyright* UNKNOWN ./tests/test-buildah.sh: *No copyright* UNKNOWN ./tests/test-runner.sh: *No copyright* UNKNOWN ./tests/test.yml: *No copyright* UNKNOWN ./vars/main.yml: *No copyright* UNKNOWN ./.github/workflows/main.yml: *No copyright* UNKNOWN ./.github/workflows/rpm.yml: *No copyright* UNKNOWN ./defaults/main/00_misc_vars.yml: *No copyright* UNKNOWN ./defaults/main/amqp1.yml: *No copyright* UNKNOWN ./defaults/main/ceph.yml: *No copyright* UNKNOWN ./defaults/main/connectivity.yml: *No copyright* UNKNOWN ./defaults/main/cpu.yml: *No copyright* UNKNOWN ./defaults/main/csv.yml: *No copyright* UNKNOWN ./defaults/main/df.yml: *No copyright* UNKNOWN ./defaults/main/disk.yml: *No copyright* UNKNOWN ./defaults/main/ethstat.yml: *No copyright* UNKNOWN ./defaults/main/exec.yml: *No copyright* UNKNOWN ./defaults/main/hugepages.yml: *No copyright* UNKNOWN ./defaults/main/intel_pmu.yml: *No copyright* UNKNOWN ./defaults/main/interface.yml: *No copyright* UNKNOWN ./defaults/main/ipmi.yml: *No copyright* UNKNOWN ./defaults/main/irq.yml: *No copyright* UNKNOWN ./defaults/main/load.yml: *No copyright* UNKNOWN ./defaults/main/logfile.yml: *No copyright* UNKNOWN ./defaults/main/memory.yml: *No copyright* UNKNOWN ./defaults/main/netlink.yml: *No copyright* UNKNOWN ./defaults/main/network.yml: *No copyright* UNKNOWN ./defaults/main/ping.yml: *No copyright* UNKNOWN ./defaults/main/processes.yml: *No copyright* UNKNOWN ./defaults/main/smart.yml: *No copyright* UNKNOWN ./defaults/main/swap.yml: *No copyright* UNKNOWN ./defaults/main/syslog.yml: *No copyright* UNKNOWN ./defaults/main/unixsock.yml: *No copyright* UNKNOWN ./defaults/main/virt.yml: *No copyright* UNKNOWN ./defaults/main/vmem.yml: *No copyright* UNKNOWN ./defaults/main/write_http.yml: *No copyright* UNKNOWN ./defaults/main/write_prometheus.yml: *No copyright* UNKNOWN ./molecule/common/requirements.yml: *No copyright* UNKNOWN ./molecule/default/INSTALL.rst: *No copyright* UNKNOWN ./molecule/default/converge.yml: *No copyright* UNKNOWN ./molecule/default/molecule.yml: *No copyright* UNKNOWN ./molecule/default/verify.yml: *No copyright* UNKNOWN ./molecule/test_network/INSTALL.rst: *No copyright* UNKNOWN ./molecule/test_network/converge.yml: *No copyright* UNKNOWN ./molecule/test_network/molecule.yml: *No copyright* UNKNOWN ./molecule/test_network/verify.yml: *No copyright* UNKNOWN ./tests/kolla_config_files/config.json: *No copyright* UNKNOWN License is fine, ASL v2
Step 2 of the packages process is a WIP here: https://review.rdoproject.org/r/#/c/31790/
Step 3 of the packages process is WIP here: https://review.rdoproject.org/r/#/c/31823/
Fedora review output:- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)". 105 files have unknown license. Detailed output of licensecheck in /tmp/ansible-role-collectd-config/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.0.1 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ansible-role-collectd-config-0.0.1-0.20210209200821.bbb4ce9.el8.noarch.rpm ansible-role-collectd-config-0.0.1-0.20210209200821.bbb4ce9.el8.src.rpm ansible-role-collectd-config.noarch: W: spelling-error Summary(en_US) configs -> con figs, con-figs, configure ansible-role-collectd-config.noarch: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure ansible-role-collectd-config.noarch: E: no-changelogname-tag ansible-role-collectd-config.src: W: spelling-error Summary(en_US) configs -> con figs, con-figs, configure ansible-role-collectd-config.src: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure ansible-role-collectd-config.src: E: no-changelogname-tag ansible-role-collectd-config.src: W: invalid-url Source0: 0.0.1-0.20210209200821.bbb4ce9.tar.gz 2 packages and 0 specfiles checked; 2 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- ansible-role-collectd-config.noarch: E: no-changelogname-tag ansible-role-collectd-config.noarch: W: invalid-url URL: https://github.com/infrawatch/collectd-config-ansible-role <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- ansible-role-collectd-config (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash python3dist(ansible) Provides -------- ansible-role-collectd-config: ansible-role-collectd-config Some issues noticed but are exempted:- - Changelog, %define and Source0 are handled by package build tool i.e DLRN. - %check is absent as tests are not shipped as part of the ansible role. Package is Approved.
Package ansible-role-collectd-config is in RDO Repos since Wallaby: tags: antelope: null bobcat: null caracal: null caracal-uc: null wallaby: null xena: source-branch: 0.0.2 yoga: source-branch: 0.0.2 zed: null