OpenShift IPI VMware installer doesn't validate the provided VIP's (API VIP and Ingress VIP) IP whether belongs to the machine CIDR provided on install-config.yaml or not.
When VIP's outside machine CIDR is used installation fails with error "ERROR:
"time="2020-12-11T18:28:30Z" level=info msg="Checking whether address x.x.x.x/25 ens192 contains VIP y.y.y.y"
time="2020-12-11T18:28:30Z" level=error msg="Failed to find a suitable node IP"""
What did you expect to happen?
Openshift installer should validate the VIP's against the machine CIDR and should abort the installation with a clear error message.
How to reproduce it
- Perform VMware IPI installation with apiVIP and ingressVIP IP's outside machine CIDR.
The `machineNetwork` field does not appear to be set universally for vSphere installations. There does not appear to be anything in the installation or the running cluster that cares what the machine CIDR is. The installer survey does not ask the user for the machine CIDR. Consequently, the installer cannot rely on the `machineNetwork` field being set. The installer cannot validate the VIPs against the machine CIDR, if the installer cannot rely on the machine CIDR being valid.