Bug 1919601 - Review Request: protontricks - Simple wrapper that does winetricks things for Proton enabled games
Summary: Review Request: protontricks - Simple wrapper that does winetricks things for...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1919600
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-24 00:44 UTC by Artem
Modified: 2021-01-26 01:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-26 01:59:12 UTC
Type: ---
Embargoed:
vitaly: fedora-review+


Attachments (Terms of Use)

Description Artem 2021-01-24 00:44:44 UTC
Spec URL: https://atim.fedorapeople.org/protontricks.spec
SRPM URL: https://atim.fedorapeople.org/protontricks-1.4.3-2.fc33.src.rpm

Description:
A simple wrapper that does winetricks things for Proton enabled games,
requires Winetricks.

This is a fork of the original project created by sirmentio. The original
repository is available at Sirmentio/protontricks.

Fedora Account System Username: atim

Comment 1 Vitaly 2021-01-25 11:43:46 UTC
I will review this package.

Comment 2 Vitaly 2021-01-25 11:57:33 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: protontricks-1.4.3-2.fc34.noarch.rpm
          protontricks-1.4.3-2.fc34.src.rpm
protontricks.noarch: W: spelling-error %description -l en_US sirmentio -> tormenting
protontricks.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/protontricks/cli.py 644 /usr/bin/env python3
protontricks.noarch: W: no-manual-page-for-binary protontricks
protontricks.src: W: spelling-error Summary(en_US) winetricks -> wine tricks, wine-tricks, trickiness
protontricks.src: W: spelling-error %description -l en_US winetricks -> wine tricks, wine-tricks, trickiness
protontricks.src: W: spelling-error %description -l en_US sirmentio -> tormenting
2 packages and 0 specfiles checked; 1 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
protontricks.noarch: W: spelling-error %description -l en_US sirmentio -> tormenting
protontricks.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/protontricks/cli.py 644 /usr/bin/env python3
protontricks.noarch: W: no-manual-page-for-binary protontricks
1 packages and 0 specfiles checked; 1 errors, 2 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/protontricks/protontricks-1.4.3.tar.gz :
  CHECKSUM(SHA256) this package     : ef65f18a2934d56d510ee03ea9031623db72ab9a22c760a97d5176bdb89e7922
  CHECKSUM(SHA256) upstream package : ef65f18a2934d56d510ee03ea9031623db72ab9a22c760a97d5176bdb89e7922


Requires
--------
protontricks (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.9dist(setuptools)
    python3.9dist(vdf)
    winetricks



Provides
--------
protontricks:
    protontricks
    python3.9dist(protontricks)
    python3dist(protontricks)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1919601 -L /media/virt/workbench/1919600-python-vdf/results/
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Perl, fonts, Haskell, SugarActivity, Ocaml, PHP, Java, C/C++, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /media/virt/workbench/1919600-python-vdf/results/python3-vdf-3.3-2.fc34.noarch.rpm

Comment 3 Vitaly 2021-01-25 11:58:42 UTC
> E: non-executable-script /usr/lib/python3.9/site-packages/protontricks/cli.py 644 /usr/bin/env python3

Please fix this rpmlint error by changing chmod to 0755 or ramoving the shebang.

Comment 4 Vitaly 2021-01-25 12:02:02 UTC
> Source0:    https://files.pythonhosted.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz

Can be replaced with:

%global pypi_name protontricks
Source0: %{pypi_source}

Comment 6 Vitaly 2021-01-25 13:35:47 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: protontricks-1.4.3-3.fc34.noarch.rpm
          protontricks-1.4.3-3.fc34.src.rpm
protontricks.noarch: W: spelling-error %description -l en_US sirmentio -> tormenting
protontricks.noarch: W: no-manual-page-for-binary protontricks
protontricks.src: W: spelling-error Summary(en_US) winetricks -> wine tricks, wine-tricks, trickiness
protontricks.src: W: spelling-error %description -l en_US winetricks -> wine tricks, wine-tricks, trickiness
protontricks.src: W: spelling-error %description -l en_US sirmentio -> tormenting
2 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
protontricks.noarch: W: spelling-error %description -l en_US sirmentio -> tormenting
protontricks.noarch: W: no-manual-page-for-binary protontricks
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/protontricks/protontricks-1.4.3.tar.gz :
  CHECKSUM(SHA256) this package     : ef65f18a2934d56d510ee03ea9031623db72ab9a22c760a97d5176bdb89e7922
  CHECKSUM(SHA256) upstream package : ef65f18a2934d56d510ee03ea9031623db72ab9a22c760a97d5176bdb89e7922


Requires
--------
protontricks (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)
    python3.9dist(setuptools)
    python3.9dist(vdf)
    winetricks



Provides
--------
protontricks:
    protontricks
    python3.9dist(protontricks)
    python3dist(protontricks)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1919601 -L /media/virt/workbench/1919600-python-vdf/results/
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: fonts, PHP, R, SugarActivity, Java, Perl, C/C++, Haskell, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /media/virt/workbench/1919600-python-vdf/results/python3-vdf-3.3-2.fc34.noarch.rpm

Comment 7 Vitaly 2021-01-25 13:36:04 UTC
LGTM now. Package approved.

Comment 8 Gwyn Ciesla 2021-01-25 15:30:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/protontricks

Comment 9 Fedora Update System 2021-01-25 16:19:45 UTC
FEDORA-2021-f74743d0db has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f74743d0db

Comment 10 Fedora Update System 2021-01-26 01:59:12 UTC
FEDORA-2021-f74743d0db has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.