Bug 1920559 - Rollback does not complete if the DVM Controller does not delete the Rsync pods
Summary: Rollback does not complete if the DVM Controller does not delete the Rsync pods
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Containers
Classification: Red Hat
Component: Controller
Version: 1.4.z
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 1.5.0
Assignee: Derek Whatley
QA Contact: Xin jiang
Avital Pinnick
URL:
Whiteboard:
: 1919023 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-01-26 15:25 UTC by Shawn Hurley
Modified: 2021-07-28 04:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-28 04:08:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github konveyor mig-controller pull 1128 0 None open Bug 1920559: Rollback DVM created resources on target cluster 2021-06-16 19:36:23 UTC
Github konveyor mig-controller pull 1130 0 None open Bug 1920559: (Cherry-pick) Rollback DVM created resources on target cluster (#1128) 2021-06-17 14:54:15 UTC
Red Hat Product Errata RHEA-2021:2929 0 None None None 2021-07-28 04:08:07 UTC

Comment 1 Derek Whatley 2021-06-16 19:37:17 UTC 
*** Bug 1919023 has been marked as a duplicate of this bug. ***
Comment 2 Derek Whatley 2021-06-16 19:39:27 UTC 
We were missing the `migrated-by-migplan` label on DVM created resources. Adding this allows rollback to work as intended.

I'm also going to see if we should modify the rollback wait routine, since it shouldn't block waiting on resources that don't have `migrated-by-migplan` label.
Comment 3 Derek Whatley 2021-06-16 19:41:30 UTC 
Upon closer inspection, the rollback was hanging because the DVM pods were stalling a PVC with the `migrated-by-migplan` label from being able to terminate fully. The posted solution should solve the BZ.
Comment 7 Sergio 2021-06-29 14:44:23 UTC 
Verified using MTC 1.5.0

   openshift-migration-rhel7-operator@sha256:00e77706ca22bcb557d13c16822180fc877e6ea1639a72fda8eb9f5488b039a2
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 7f657df15e9514df4ef42da3431f558a19b8d3233a2ef1222cd8e27793c93816


The dvm pods and the route are deleted, and the rollback is executed without problems, it is not stuck any more.

On the other hand DVM services, secrets and configuration maps are not deleted. We will open a separate BZ for this issue.

Moved to VERIFIED.
Comment 13 errata-xmlrpc 2021-07-28 04:08:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) image release advisory 1.5.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2929
Note You need to log in before you can comment on or make changes to this bug.