Spec URL: https://raw.githubusercontent.com/EricEdens/fedora-packages/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/ericedens/gcp-guest-packages/build/1905931/ Description: Logging facade for Google Cloud Platform guest agents. Required to complete <https://pagure.io/cloud-sig/issue/313>. Fedora Account System Username: ericedens
The "Fedora Account System Username" should be your username in FAS, not your email address. Could you please edit it to fix that?
done!
Taking this review.
Eric, the SRPM URL is wrong too. It needs to be the direct path to the SRPM file built in COPR. Could you please update it to fix that?
Updated
Can you please update the Spec URL to point to the raw path to the spec file itself (not the Github rendered HTML version)? fedora-review is choking on the current URL. ngompa@fedkde-ryo-ohki-winvm ~> fedora-review -b 1920606 -m fedora-rawhide-x86_64 INFO: Processing bugzilla bug: 1920606 INFO: Getting .spec and .srpm Urls from : 1920606 INFO: --> SRPM url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm INFO: --> Spec url: https://github.com/EricEdens/fedora-packages/blob/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec INFO: Using review directory: /home/ngompa/1920606-golang-github-googlecloudplatform-guest-logging INFO: Downloading .spec and .srpm files error: line 7: Unknown tag: <!DOCTYPE html> ERROR: "Can't parse specfile: can't parse specfile\n" (logs in /home/ngompa/.cache/fedora-review.log) Exception ignored in: <FedoraReview.spec_file._Null object at 0x7f8ba7177940> AttributeError: '_Null' object has no attribute 'flush'
fedora-review appears to take the last links on the page, so adding the correct ones here: Spec URL: https://raw.githubusercontent.com/EricEdens/fedora-packages/google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01905931-golang-github-googlecloudplatform-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210126git6cbb518.fc33.src.rpm
Package was generated through go2rpm, simplifying the review considerably. - Conforms to packaging guidelines (go2rpm generated spec) - license correct and valid - only sources installed - no serious issues from rpmlint PACKAGE APPROVED.
I've sponsored Eric Edens as a packager. Welcome to the Fedora packagers group! Now you are now able to proceed to the next step in the process to add this package to Fedora.
Great, thanks! Last iteration fixes the lint errors: Spec URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01930355-google-guest-logging/golang-github-googlecloudplatform-guest-logging.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packages/fedora-33-x86_64/01930355-google-guest-logging/golang-github-googlecloudplatform-guest-logging-0-1.20210202git6cbb518.fc33.src.rpm
Nice work Eric! Thanks Neal!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-logging